Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip to 20.2.2, setuptools to 49.6.0 #30317

Closed
mkoeppe opened this issue Aug 7, 2020 · 19 comments
Closed

Update pip to 20.2.2, setuptools to 49.6.0 #30317

mkoeppe opened this issue Aug 7, 2020 · 19 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Aug 7, 2020

Previous update: #29803 (20.1.1, 47.1.1)

CC: @jhpalmieri @dimpase

Component: packages: standard

Author: Matthias Koeppe

Branch: 51eac01

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30317

@mkoeppe mkoeppe added this to the sage-9.2 milestone Aug 7, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 7, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 7, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 7, 2020

Commit: 91f21f6

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 7, 2020

New commits:

a22b6aebuild/pkgs/pip: Update to 20.2.1
91f21f6build/pkgs/setuptools: Update to 49.2.1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2020

Changed commit from 91f21f6 to eded6be

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

eded6bebuild/pkgs/pip: Update to 20.2.2

@mkoeppe mkoeppe changed the title Update pip to 20.2.1, setuptools to 49.2.1 Update pip to 20.2.2, setuptools to 49.2.1 Aug 28, 2020
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

51eac01build/pkgs/setuptools: Update to 49.6.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2020

Changed commit from eded6be to 51eac01

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Update pip to 20.2.2, setuptools to 49.2.1 Update pip to 20.2.2, setuptools to 49.6.0 Aug 28, 2020
@tobiasdiez
Copy link
Contributor

comment:7

I tried this as recommended in #30459, but it fails with "Error downloading pip-20.2.2.tar.gz" because this version of pip cannot be found on any of the sage mirrors apparently. Do I have to change something before running this branch?

Just out of interest, what is the reason for this spkg infrastructure over say pipenv + pipfile?

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 28, 2020

comment:8

Replying to @tobiasdiez:

I tried this as recommended in #30459, but it fails with "Error downloading pip-20.2.2.tar.gz" because this version of pip cannot be found on any of the sage mirrors apparently. Do I have to change something before running this branch?

Tickets with package changes need ./configure --enable-download-from-upstream-url until the ticket has been merged into the next beta (which is when the release manager uploads the tarballs to the mirrors).

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 28, 2020

comment:9

Replying to @tobiasdiez:

Just out of interest, what is the reason for this spkg infrastructure over say pipenv + pipfile?

If you are asking why we bypass proper package management by pip and install things in the most basic way using pip --ignore-installed --verbose --no-deps --no-index (see build/bin/sage-pip-install)... let's just say that it is the result of design decisions made a long time ago based on implementation constraints that were valid at that time - but no longer bind us now.

I am hoping that we can make the installation of Python packages more straightforward in the Sage 9.3 cycle. #29500 (Install all Python packages via pip wheel) is a step in this direction.

I haven't looked at pipenv in detail; pipfile looks like it is far from a stable version

@tobiasdiez
Copy link
Contributor

comment:10

After configure it downloaded pip. However, the installation failed with the same error as reported in #30459. I also tried to add with_pip=True in the constructor argument of EnvBuilder in sage-venv, but this script doesn't seem to be triggered at all during a make.

Thanks for the explanation. It's interesting to learn more about the inner workings of sage. Pipfile is as stable as pipenv, since the latter uses it heavily. But if I understand it correctly, you are not using a virtual environment for the local python installation, right?

@jhpalmieri
Copy link
Member

comment:12

Looks like a straightforward update to me. It works for me on OS X. Other issues could be addressed on another ticket: the problems reported by @tobiasdiez look like they're independent of the changes here, unless I'm misunderstanding.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 31, 2020

comment:13

Thanks!

@vbraun
Copy link
Member

vbraun commented Sep 6, 2020

Changed branch from u/mkoeppe/update_pip_to_20_2_1__setuptools_to_49_2_1 to 51eac01

@slel
Copy link
Member

slel commented Sep 26, 2020

Changed commit from 51eac01 to none

@slel
Copy link
Member

slel commented Sep 26, 2020

comment:15

50.0.0 will bring backward-incompatible changes;
see ​https://setuptools.readthedocs.io/en/latest/history.html#v50-0-0

Some if not all these changes are reverted in 50.1.0, 50.2.0, 50.3.0,
see history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants