Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matplotlib to 3.3.1, certifi to 2020.6.20 #30358

Closed
mkoeppe opened this issue Aug 14, 2020 · 19 comments
Closed

Update matplotlib to 3.3.1, certifi to 2020.6.20 #30358

mkoeppe opened this issue Aug 14, 2020 · 19 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Aug 14, 2020

https://github.com/matplotlib/matplotlib/milestone/56?closed=1

certifi is a new dependency, we are upgrading to the latest version.

Previous update:

CC: @jhpalmieri @kiwifb @timokau @egourgoulhon @antonio-rojas

Component: packages: standard

Keywords: upgrade, matplotlib, certifi

Author: Matthias Koeppe

Branch/Commit: d8e4aab

Reviewer: Samuel Lelièvre, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30358

@mkoeppe mkoeppe added this to the sage-9.2 milestone Aug 14, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 14, 2020

Branch: u/mkoeppe/update_matplotlib_to_3_3_1

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 14, 2020

New commits:

6c7fa3abuild/pkgs/matplotlib: Update to 3.3.1

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 14, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 14, 2020

Commit: 6c7fa3a

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 14, 2020

comment:3
    setup_requires=[
        "certifi>=2020.06.20",
        "numpy>=1.15",
    ],
    install_requires=[
        "certifi>=2020.06.20",
        "cycler>=0.10",
        "kiwisolver>=1.0.1",
        "numpy>=1.15",
        "pillow>=6.2.0",
        "pyparsing>=2.0.3,!=2.0.4,!=2.1.2,!=2.1.6",
        "python-dateutil>=2.1",
    ],

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2020

Changed commit from 6c7fa3a to a4c2524

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

a4c2524build/pkgs/certifi: Update to 2020.6.20

@mkoeppe mkoeppe changed the title Update matplotlib to 3.3.1 Update matplotlib to 3.3.1, certifi to 2020.6.20 Aug 14, 2020
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2020

Changed commit from a4c2524 to d8e4aab

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

d8e4aabbuild/pkgs/matplotlib/dependencies: Add certifi

@mkoeppe

This comment has been minimized.

@slel
Copy link
Member

slel commented Aug 20, 2020

Reviewer: Samuel Lelièvre

@slel
Copy link
Member

slel commented Aug 20, 2020

comment:9

On Debian 10 "buster": make testlong: All tests passed!

Anything to test in particular?

@slel
Copy link
Member

slel commented Aug 20, 2020

Changed keywords from none to upgrade, matplotlib, certifi

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 20, 2020

comment:10

Visual inspection of graphics, for example in the built manual, would help - because this is something that our testsuite cannot do

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 27, 2020

comment:11

Let's get this update in please

@jhpalmieri
Copy link
Member

comment:12

I did a little spot-checking, both the reference manual and some plots by hand, and everything looks good.

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 27, 2020

comment:13

Thank you!

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 28, 2020

Changed reviewer from Samuel Lelièvre to Samuel Lelièvre, John Palmieri

@vbraun
Copy link
Member

vbraun commented Sep 1, 2020

Changed branch from u/mkoeppe/update_matplotlib_to_3_3_1 to d8e4aab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants