Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable LTO in matplotlib build #30365

Closed
mkoeppe opened this issue Aug 15, 2020 · 10 comments
Closed

Disable LTO in matplotlib build #30365

mkoeppe opened this issue Aug 15, 2020 · 10 comments
Labels
c: packages: standard p: critical / 2 t: bug
Milestone
sage-9.2

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Aug 15, 2020

matplotlib's setup.py by default adds an -flto flag to CFLAGS. This can cause errors in the linking stage if we mix two compiler versions, as observed in #27754.

We disable it.

CC: @orlitzky @antonio-rojas @dimpase @jhpalmieri @kiwifb

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 2d16e5d

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/30365
@mkoeppe mkoeppe added this to the sage-9.2 milestone Aug 15, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 15, 2020

Branch: u/mkoeppe/disable_lto_in_matplotlib_build

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 15, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 15, 2020

Commit: 2d16e5d

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 15, 2020

New commits:

2d16e5dbuild/pkgs/matplotlib/make-setup-config.py: Disable LTO

@kiwifb
Copy link
Member

kiwifb commented Aug 15, 2020

comment:3

This is really straightforward and easy.

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 15, 2020

comment:4

I have tested it successfully on debian-bullseye (with #27754, which exposed this problem).

@kiwifb
Copy link
Member

kiwifb commented Aug 15, 2020

Reviewer: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Aug 15, 2020

comment:5

Let's ship it then.

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 15, 2020

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Aug 16, 2020

Changed branch from u/mkoeppe/disable_lto_in_matplotlib_build to 2d16e5d

@vbraun vbraun closed this as completed in e18e842 Aug 16, 2020
@slel slel mentioned this issue Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@kiwifb @vbraun @mkoeppe