Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphs: fix bug in OrthogonalDualPolarGraph due to pointless conversion to float #30439

Closed
Ivo-Maffei mannequin opened this issue Aug 25, 2020 · 6 comments
Closed

Graphs: fix bug in OrthogonalDualPolarGraph due to pointless conversion to float #30439

Ivo-Maffei mannequin opened this issue Aug 25, 2020 · 6 comments
Labels
c: graph theory p: major / 3 t: bug
Milestone
sage-9.2

Comments

@Ivo-Maffei
Copy link
Mannequin

Ivo-Maffei mannequin commented Aug 25, 2020

In graphs.OrthogonalDualPolarGraph if the parameter q is an int, then python converts the intersection size to a float and GAP complains about it:

sage: graphs.OrthogonalDualPolarGraph(1, 3, int(2))
...
AttributeError: 'float' object has no attribute '_libgap_init_'

This is fixed by using integer division //.

CC: @dimpase

Component: graph theory

Author: Ivo Maffei

Branch/Commit: 10a1ca1

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30439
@Ivo-Maffei Ivo-Maffei mannequin added this to the sage-9.2 milestone Aug 25, 2020
@Ivo-Maffei
Copy link
Mannequin Author

Ivo-Maffei mannequin commented Aug 25, 2020

Commit: 10a1ca1

@Ivo-Maffei
Copy link
Mannequin Author

Ivo-Maffei mannequin commented Aug 25, 2020

Branch: public/graphs/30439

@Ivo-Maffei
Copy link
Mannequin Author

Ivo-Maffei mannequin commented Aug 25, 2020

New commits:

10a1ca1integer division in orthogonal dual polar

@Ivo-Maffei Ivo-Maffei mannequin added the s: needs review label Aug 25, 2020
@dimpase
Copy link
Member

dimpase commented Aug 25, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Aug 25, 2020

comment:3

lgtm

@vbraun
Copy link
Member

vbraun commented Aug 30, 2020

Changed branch from public/graphs/30439 to 10a1ca1

@vbraun vbraun closed this as completed in 5392617 Aug 30, 2020
@Ivo-Maffei Ivo-Maffei mannequin mentioned this issue Jan 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
2 participants
@vbraun @dimpase