notebook -- add a "remember me" checkbox to the login page.

[TimothyClemans]

Many webpages have a little "remember me" checkbox to determine whether you have to enter login credentials every time you visit a web page. Possibly implement something similar in Sage.

Component: notebook

Issue created by migration from https://trac.sagemath.org/ticket/3050

[williamstein]

comment:1

The Knoboo people have this feature. Timothy attached a patch that is relevant to their implementation, which might be of some use to whoever implements this for sage.

[TimothyClemans]

comment:2

I want to make it clear that this functionality is not in Knoboo currently. From Alex Clemesha, "We will get this into knoboo as soon as the "settings" functionality
starts to settle into knoboo, because, (as you would probably agree), this only thing missing with the patch would be a way for the Admin user to set the "expires time" (instead of hard-coded)."

[TimothyClemans]

Attachment: extcode-3050.patch.gz

[TimothyClemans]

comment:3

Fixes #3155 also.

[TimothyClemans]

comment:4

Warning: Depends on #3213

[williamstein]

comment:5

REVIEW:

1. It would be nice if you added a comment about what is going on in the modifications to twist.py.

2. I don't actually understand how to test that this patch is actually doing something! Could you give me simple step-by-step instructions to test out a situation where the behavior of something is different whether or not remember me is checked? Does this feature only do anything when there are multiple accounts? I tried what I thought was the obvious test, and it seems like Remember Me just doesn't work. We can figure this out at the cafe today.

[sagetrac-mabshoff]

comment:7

Merged all three patches in Sage 3.0.2.alpha1

[williamstein]

comment:8

Hi,

I was just using Sage on my computer with this patch applied and having a lot of problems if I open and close my browser. I get into a state where I absolutely can't login, etc.

I.e., this patch is definitely not ready for prime time. It will break the notebook for a lot of people in confusing ways.

We'll get it fixed though.

[TimothyClemans]

new and includes sage-3050.patch and sage-3050_2.patch

[TimothyClemans]

comment:10

Attachment: trac_3050-revised-sage-3050.patch.gz

I changed the cookie name to the static name "nb_session" in both the render for UserToplevel and in the function get_our_cookie in guard.py. I don't know if doing this fixes the problem.

[williamstein]

comment:11

The new patch works.

[williamstein]

comment:12

The new patch still causes problems, where notebooks just "don't work". This is very serious and would cause mass problems by users.

[williamstein]

comment:13

Wait, I spoke too soon. I was confused by another separate problem.

[sagetrac-mabshoff]

comment:14

Merged extcode-3050.patch and trac_3050-revised-sage-3050.patch in Sage 3.0.2.alpha1