Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pycodestyle E701/E702 in combinat #30514

Closed
fchapoton opened this issue Sep 6, 2020 · 11 comments
Closed

fix pycodestyle E701/E702 in combinat #30514

fchapoton opened this issue Sep 6, 2020 · 11 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.2

Comments

@fchapoton
Copy link
Contributor

namely have one command per line

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 1d3c652

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/30514
@fchapoton fchapoton added this to the sage-9.2 milestone Sep 6, 2020
@fchapoton
Copy link
Contributor Author

Commit: 86ed108

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30514

@fchapoton
Copy link
Contributor Author

New commits:

86ed108fix pycodestyle E701 and E702 in combinat (one command per line)

@dcoudert
Copy link
Contributor

dcoudert commented Sep 6, 2020

comment:2

may be you could also do changes like

-                    j=(j+1)%(k+1)
+                    j = (j + 1) % (k + 1)

@fchapoton
Copy link
Contributor Author

comment:3

J'ai essayé, autant que possible, de refrener mon envie de faire des changements pep8 tout autour. Ca augmente les risques de conflits de fusion, et c'est pas le but du ticket.

@dcoudert
Copy link
Contributor

dcoudert commented Sep 6, 2020

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

dcoudert commented Sep 6, 2020

comment:4

OK. LGTM.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 11, 2020

Changed commit from 86ed108 to 1d3c652

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 11, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

1d3c652Merge branch 'u/chapoton/30514' of ssh://trac.sagemath.org:22/sage into 9.2.b12

@fchapoton
Copy link
Contributor Author

comment:6

just rebased for a conflict in tableau.py, setting back to positive

@vbraun
Copy link
Member

vbraun commented Sep 23, 2020

Changed branch from u/chapoton/30514 to 1d3c652

@vbraun vbraun closed this as completed in 6844bbe Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert