Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quiet mode for bootstrap #30533

Closed
slel opened this issue Sep 8, 2020 · 18 comments
Closed

Add quiet mode for bootstrap #30533

slel opened this issue Sep 8, 2020 · 18 comments

Comments

@slel
Copy link
Member

slel commented Sep 8, 2020

This ticket is to add a -q flag to bootstrap
so that it will print out less.

CC: @orlitzky @mkoeppe @slel

Component: build: configure

Keywords: quiet

Author: Michael Orlitzky

Branch: 9c39bc8

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30533

@slel slel added this to the sage-9.2 milestone Sep 8, 2020
@orlitzky
Copy link
Contributor

Author: Michael Orlitzky

@orlitzky
Copy link
Contributor

Branch: u/mjo/ticket/30533

@orlitzky
Copy link
Contributor

comment:1

Somebody want to come up with usage() strings for the other options? I'm not really sure what they're meant to do.


New commits:

f537959Trac #30533: add new -q (quiet) flag for the bootstrap process.
6547b33Trac #30533: hide automake (stderr) output from ./bootstrap -q.
8c2efbfTrac #30533: improve ./bootstrap usage() a bit.
8f91dbcTrac #30533: whitespace cleanup in ./bootstrap.

@orlitzky
Copy link
Contributor

Commit: 8f91dbc

@slel
Copy link
Member Author

slel commented Sep 11, 2020

comment:2

My understanding is:

  -d        download a pre-made `configure` script
  -D        download and ensure future invocations will download too
  -s        save the `configure` script
  -u <URL>  use <URL> as the download url for a pre-made `configure` script
  -?        print this help and exit with an error

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2020

Changed commit from 8f91dbc to 59185e6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

33c5fccTrac #30533: improve ./bootstrap usage() a bit.
aa238d5Trac #30533: whitespace cleanup in ./bootstrap.
ab1cedaTrac #30533: rename bootstrap-download() to bootstrap_download().
63d539fTrac #30533: use /bin/sh to run the bootstrap script instead of bash.
3f4c45aTrac #30533: hide output from "./bootstrap -s" in quiet mode.
59185e6Trac #30533: hide info output from "./bootstrap -D" in quiet mode.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2d443aeTrac #30533: improve ./bootstrap usage() a bit.
c6ed563Trac #30533: whitespace cleanup in ./bootstrap.
31cb178Trac #30533: rename bootstrap-download() to bootstrap_download().
358ddc5Trac #30533: use /bin/sh to run the bootstrap script instead of bash.
de351f1Trac #30533: hide output from "./bootstrap -s" in quiet mode.
912af9bTrac #30533: hide info output from "./bootstrap -D" in quiet mode.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2020

Changed commit from 59185e6 to 912af9b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

171b947Trac #30533: improve ./bootstrap usage() a bit.
7dcb5a8Trac #30533: whitespace cleanup in ./bootstrap.
ab83893Trac #30533: rename bootstrap-download() to bootstrap_download().
2b4272dTrac #30533: use /bin/sh to run the bootstrap script instead of bash.
b85f4a1Trac #30533: hide output from "./bootstrap -s" in quiet mode.
9c39bc8Trac #30533: hide info output from "./bootstrap -D" in quiet mode.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2020

Changed commit from 912af9b to 9c39bc8

@orlitzky
Copy link
Contributor

comment:6

All good now, I hope. The output should be hidden from ./bootstrap -s -q and ./bootstrap -D -q now too.

@mkoeppe
Copy link
Member

mkoeppe commented Sep 15, 2020

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Member

mkoeppe commented Sep 15, 2020

comment:7

This is a nice improvement

@vbraun
Copy link
Member

vbraun commented Sep 23, 2020

Changed branch from u/mjo/ticket/30533 to 9c39bc8

@mkoeppe
Copy link
Member

mkoeppe commented Sep 25, 2020

Changed commit from 9c39bc8 to none

@mkoeppe
Copy link
Member

mkoeppe commented Sep 25, 2020

comment:9

Actually the change from bash to /bin/sh seems to have changed the set -e default, and bootstrap no longer works if src/bin/sage-env-config does not already exist.

@mkoeppe
Copy link
Member

mkoeppe commented Sep 25, 2020

comment:10

Follow-up: #30664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants