Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various flake8 fixes #30542

Closed
fchapoton opened this issue Sep 9, 2020 · 9 comments
Closed

various flake8 fixes #30542

fchapoton opened this issue Sep 9, 2020 · 9 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.3

Comments

@fchapoton
Copy link
Contributor

about E7 warnings (one command per line, etc)

in arith, calculus, homology, matroids, parallel

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 48931bd

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30542
@fchapoton fchapoton added this to the sage-9.3 milestone Sep 9, 2020
@fchapoton
Copy link
Contributor Author

New commits:

c10561avarious minor flake8 fixes (about E7)

@fchapoton
Copy link
Contributor Author

Commit: c10561a

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30542

@tscrim
Copy link
Collaborator

tscrim commented Sep 9, 2020

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Sep 9, 2020

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 22, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

48931bdMerge branch 'u/chapoton/30542' in 9.2.b13

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 22, 2020

Changed commit from c10561a to 48931bd

@fchapoton
Copy link
Contributor Author

comment:4

trivial rebase, setting back to positive

@vbraun
Copy link
Member

vbraun commented Nov 7, 2020

Changed branch from u/chapoton/30542 to 48931bd

@vbraun vbraun closed this as completed in 38bab5a Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton