Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some cleanup (flake8) in poset files #30553

Closed
fchapoton opened this issue Sep 11, 2020 · 10 comments
Closed

some cleanup (flake8) in poset files #30553

fchapoton opened this issue Sep 11, 2020 · 10 comments
Labels
c: combinatorics p: minor / 4 t: enhancement
Milestone
sage-9.3

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: a36b597

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30553
@fchapoton fchapoton added this to the sage-9.2 milestone Sep 11, 2020
@fchapoton
Copy link
Contributor Author

New commits:

45e24b7cleaning some posets files

@fchapoton
Copy link
Contributor Author

Commit: 45e24b7

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30553

@fchapoton
Copy link
Contributor Author

comment:2

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Sep 13, 2020

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Sep 13, 2020

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

a36b597Merge branch 'u/chapoton/30553' in 9.2.b14

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2020

Changed commit from 45e24b7 to a36b597

@fchapoton
Copy link
Contributor Author

comment:5

trivial rebase, setting back to positive

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@vbraun
Copy link
Member

vbraun commented Nov 7, 2020

Changed branch from u/chapoton/30553 to a36b597

@vbraun vbraun closed this as completed in 973606c Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
4 participants
@vbraun @tscrim @fchapoton @mkoeppe