Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maple conversion for hypergeometric functions #30575

Closed
fchapoton opened this issue Sep 15, 2020 · 13 comments
Closed

add maple conversion for hypergeometric functions #30575

fchapoton opened this issue Sep 15, 2020 · 13 comments

Comments

@fchapoton
Copy link
Contributor

If Maple is installed one can do:

sage: F = hypergeometric([-4, 2], [1], 1)
sage: G = maple(F); G
hypergeometric([-4, 2],[1],1)

From there, before this ticket:

sage: G.simplify()
hypergeometric([-4, 2],[1],1)

After this ticket:

sage: G.simplify()
0

CC: @slel

Component: symbolics

Keywords: maple

Author: Frédéric Chapoton

Branch/Commit: a6087aa

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/30575

@fchapoton fchapoton added this to the sage-9.3 milestone Sep 15, 2020
@fchapoton
Copy link
Contributor Author

New commits:

6210836add maple conversion for hypergeometric functions

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30575

@fchapoton
Copy link
Contributor Author

Commit: 6210836

@fchapoton fchapoton changed the title add maple conversion for hypergeomtric functions add maple conversion for hypergeometric functions Sep 15, 2020
@slel
Copy link
Member

slel commented Sep 15, 2020

comment:2

Add a doctest to check this works?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2020

Changed commit from 6210836 to a6087aa

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

a6087aaadding one doctest

@fchapoton
Copy link
Contributor Author

comment:4

Voici !

@fchapoton
Copy link
Contributor Author

comment:5

and the bot is green ! please review

@slel
Copy link
Member

slel commented Sep 15, 2020

Reviewer: Samuel Lelièvre

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Sep 15, 2020

Changed keywords from none to maple

@slel
Copy link
Member

slel commented Sep 15, 2020

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Sep 27, 2020

Changed branch from u/chapoton/30575 to a6087aa

@vbraun vbraun closed this as completed in 0b841a7 Sep 27, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.2 Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants