Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/sage/cpython/debugimpl.c: remove python2 code #30590

Closed
mkoeppe opened this issue Sep 17, 2020 · 14 comments
Closed

src/sage/cpython/debugimpl.c: remove python2 code #30590

mkoeppe opened this issue Sep 17, 2020 · 14 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.2

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Sep 17, 2020

(from #30371)

This straightforward cleanup is preparation for necessary changes for Python 3.9 (#30184)

CC: @tobiasdiez @jdemeyer

Component: refactoring

Author: Tobias Diez

Branch/Commit: 8f71b29

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30590
@mkoeppe mkoeppe added this to the sage-9.2 milestone Sep 17, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 17, 2020

Branch: u/mkoeppe/src_sage_cpython_debugimpl_c__remove_python2_code

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2020

Commit: 8f71b29

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8f71b29src/sage/cpython/debugimpl.c: Remove python2 code

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 17, 2020

Reviewer: Matthias Koeppe

@tobiasdiez
Copy link
Contributor

comment:5

Thanks!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2020

comment:6

(push to wrong ticket)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2020

Changed commit from 8f71b29 to 231f17f

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 17, 2020

comment:7

whoops, wrong ticket

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 17, 2020

comment:8

(deleted)

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 17, 2020

comment:9

(deleted)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2020

Changed commit from 231f17f to 8f71b29

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

@vbraun
Copy link
Member

vbraun commented Oct 3, 2020

Changed branch from u/mkoeppe/src_sage_cpython_debugimpl_c__remove_python2_code to 8f71b29

@vbraun vbraun closed this as completed in a1810d5 Oct 3, 2020
@slel slel mentioned this issue Oct 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @tobiasdiez @mkoeppe