Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a sparse bitset structure #30597

Closed
kliem opened this issue Sep 18, 2020 · 7 comments
Closed

Define a sparse bitset structure #30597

kliem opened this issue Sep 18, 2020 · 7 comments

Comments

@kliem
Copy link
Contributor

kliem commented Sep 18, 2020

This structure is a copy of bitset_t for now and at the moment mainly illustrates that the entire setup with a fused type in biteset.pxi works.

After combinatorial polyhedron uses this type for its atom-representation it should contain some additional information about which limbs are relevant. So it will increase slightly in memory usage, while still using constant memory (dependent on size). However, access to non-zero limbs will be improved.

Depends on #30572
Depends on #30596

CC: @tscrim

Component: cython

Keywords: sparse bitset

Author: Jonathan Kliem

Branch/Commit: 9d3ebc7

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30597

@kliem kliem added this to the sage-9.2 milestone Sep 18, 2020
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 18, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9d3ebc7define sparse_bitset_t

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 18, 2020

Changed commit from 2f2b73f to 9d3ebc7

@kliem kliem modified the milestones: sage-9.2, sage-9.3 Sep 18, 2020
@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2020

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2020

Reviewer: Travis Scrimshaw

@kliem
Copy link
Contributor Author

kliem commented Sep 21, 2020

comment:5

Thank you.

@vbraun
Copy link
Member

vbraun commented Sep 30, 2020

Changed branch from u/gh-kliem/sparse_bitsets_via_fuzed_types to 9d3ebc7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants