Define a new data structure for a list of combinatorial faces

[kliem]

We define a new data structure for a lists of combinatorial faces.

The corresponding functions will replace the functions in bit_vector_operations.cc and now are factored out to bitsets.

See #30549 for doctesting.

Depends on #30598

CC: @tscrim

Component: geometry

Keywords: face list data structure

Author: Jonathan Kliem

Branch/Commit: 7a40b9a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30599

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

a369269	put imports in order
bb33866	import instead of include
689bd4d	new data structure for a combinatorial face of a polyhedron
d644669	put imports in order
7cc7fcd	added file
f1f9499	face_list_t
02eabff	add find and sort
50317b0	fixes to list_of_faces.pxi
32cf17e	remove pxi file
c81f438	move not inlined functions to pyx file

[sagetrac-git]

Changed commit from aaa46d8 to c81f438

[tscrim]

comment:3

The cdef void sort_faces_list(face_list_t faces): seems strange. I don't see why there needs to be a return in the if because there is no remainder of the function. Did something get lost?

Trivial, but not C :P in cdef inline size_t get_next_level_fused: faces.n_faces -= 1;

[sagetrac-git]

Changed commit from c81f438 to 7a40b9a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7a40b9a

redundant exit; removed semicolon

[kliem]

comment:5

Replying to @tscrim:

The cdef void sort_faces_list(face_list_t faces): seems strange. I don't see why there needs to be a return in the if because there is no remainder of the function. Did something get lost?

Trivial, but not C :P in cdef inline size_t get_next_level_fused: faces.n_faces -= 1;

Done.

The return is still needed, but only in one place (out of two). In sort_faces_list it is indeed redundant. A few lines down it is still present.

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:6

I agree that it is needed for _sort_faces_loop.

Thank you. LGTM.

[vbraun]

Changed branch from u/gh-kliem/data_structure_for_face_list to 7a40b9a