Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitions_n.__iter__ creates partitions with int (instead of Integer) parts #30602

Closed
mantepse opened this issue Sep 18, 2020 · 11 comments
Closed

Comments

@mantepse
Copy link
Collaborator

Several iterators over partitions return partitions whose parts are of type int instead of Integer:

sage: type(Partitions(3)[0][0])
<class 'int'>
sage: type(Partitions(3, length=3)[0][0])
<class 'int'>

sage: type(Partitions(3, max_part=3)[0][0])
<class 'sage.rings.integer.Integer'>

Component: combinatorics

Author: Mike Hansen

Branch/Commit: 82e30dc

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30602

@mantepse mantepse added this to the sage-9.2 milestone Sep 18, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe
Copy link
Member

mkoeppe commented May 10, 2021

comment:2

Moving to 9.4, as 9.3 has been released.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 May 10, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 22, 2021
@mwhansen
Copy link
Contributor

@fchapoton
Copy link
Contributor

Commit: 82e30dc

@fchapoton
Copy link
Contributor

comment:5

you should set to "needs review" if this is ready


New commits:

82e30dcTrac #30602: Use Integer when creating Partition objects from ZS1_* iterators

@slel
Copy link
Member

slel commented Sep 23, 2021

comment:6

... and fill in author name (done now).

@slel
Copy link
Member

slel commented Sep 23, 2021

Author: Mike Hansen

@mwhansen
Copy link
Contributor

comment:7

Sorry -- I had been waiting for the patchbot build to run before marking it needs_review.

@slel
Copy link
Member

slel commented Sep 24, 2021

comment:8

And the patchbot was waiting for the author field to be filled in. : )

@tscrim
Copy link
Collaborator

tscrim commented Oct 3, 2021

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 3, 2021

comment:9

Good catch. LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 10, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants