Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade readline to 8.0 #30603

Closed
jhpalmieri opened this issue Sep 18, 2020 · 12 comments
Closed

Upgrade readline to 8.0 #30603

jhpalmieri opened this issue Sep 18, 2020 · 12 comments

Comments

@jhpalmieri
Copy link
Member

This helps build with Xcode 12 on OS X.

https://ftp.gnu.org/gnu/readline/readline-8.0.tar.gz

CC: @embray

Component: packages: standard

Author: John Palmieri

Branch/Commit: 3e7b084

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30603

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member Author

comment:1

The file sigsetjmp.patch doesn't apply anymore, so I removed it. The new version needs to be tested on various platforms, including cygwin (which is what this patch was for, apparently).

@jhpalmieri
Copy link
Member Author

Author: John Palmieri

@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/readline-8.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 18, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

3e7b084readline: add upstream_url field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 18, 2020

Commit: 3e7b084

@jhpalmieri
Copy link
Member Author

comment:5

Marking as critical since there is a working homebrew package that can be used in place of Sage's readline.

@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2020

comment:6

This seems to work well, as tested for example in https://github.com/mkoeppe/sage/actions/runs/268683330

@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2020

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2020

comment:7

(The package builds correctly on cygwin-minimal (https://github.com/mkoeppe/sage/runs/1154771531).)

@jhpalmieri
Copy link
Member Author

comment:8

Replying to @mkoeppe:

(The package builds correctly on cygwin-minimal (https://github.com/mkoeppe/sage/runs/1154771531).)

Great, thank you for checking that!

@vbraun
Copy link
Member

vbraun commented Sep 30, 2020

Changed branch from u/jhpalmieri/readline-8.0 to 3e7b084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants