Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiled cython and virtual environments in gitignore #30673

Closed
tobiasdiez opened this issue Sep 27, 2020 · 15 comments
Closed

Add compiled cython and virtual environments in gitignore #30673

tobiasdiez opened this issue Sep 27, 2020 · 15 comments

Comments

@tobiasdiez
Copy link
Contributor

As preparation for #30371, the gitignore file is extended to ignore compiled cython files (e.g. *.so) as well as the virtual environments (e.g. src/.venv). These changes are more or less copied from https://www.toptal.com/developers/gitignore/api/python,visualstudiocode.

Finally, I've also taken the opportunity to change to comments to a consistent format (simple single line comments).

Depends on #30730

CC: @mkoeppe

Component: build

Author: Tobias Diez

Branch/Commit: d35c945

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30673

@tobiasdiez tobiasdiez added this to the sage-9.2 milestone Sep 27, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Sep 27, 2020

comment:2

This vscode configuration does not make sense without #30371. In a normal Sage build, the venv directory is local/.

Best to have two separate tickets for two separate issues.

Also, these ones here are not correct because we do have a few *.c and *.cpp files that should not be .gitignored.

+# Generated Cython files
+src/sage/**/*.c
+src/sage/**/*.cpp

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 28, 2020

Changed commit from 6eb3845 to bbe73ee

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 28, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

bbe73eeRemove VS code settings, and add exceptions for already checked-in files

@tobiasdiez
Copy link
Contributor Author

comment:4

Ok, I've added the already checked-in C/C++ files as exceptions. Also moved the VS code settings files to the new ticket #30677.

@tobiasdiez

This comment has been minimized.

@tobiasdiez
Copy link
Contributor Author

comment:6

It would be nice if this could be reviewed and merged rather quickly, as it's hard for me to work on other branches right now because of the large number of untracked files (>5k) coming from the editable install.

@tobiasdiez
Copy link
Contributor Author

Author: Tobias Diez

@mkoeppe
Copy link
Member

mkoeppe commented Oct 20, 2020

comment:8

I'll merge in #30730 (which is on its way into the next rc) to resolve a merge conflict

@mkoeppe
Copy link
Member

mkoeppe commented Oct 20, 2020

Dependencies: #30730

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

75df605Fix PSage.is_locked
d35c945Merge branch 'u/vbraun/more_random_failures_in_src_sage_interfaces_psage_py' of git://trac.sagemath.org/sage into t/30673/public/build/enhancegitignore

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2020

Changed commit from bbe73ee to d35c945

@mkoeppe
Copy link
Member

mkoeppe commented Oct 20, 2020

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Member

mkoeppe commented Oct 20, 2020

comment:11

Unlikely that it will make it into 9.2 though.

@tobiasdiez
Copy link
Contributor Author

comment:12

Thanks nonetheless!

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@vbraun
Copy link
Member

vbraun commented Nov 7, 2020

Changed branch from public/build/enhancegitignore to d35c945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants