New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compiled cython and virtual environments in gitignore #30673
Comments
comment:2
This vscode configuration does not make sense without #30371. In a normal Sage build, the venv directory is Best to have two separate tickets for two separate issues. Also, these ones here are not correct because we do have a few *.c and *.cpp files that should not be
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
Ok, I've added the already checked-in C/C++ files as exceptions. Also moved the VS code settings files to the new ticket #30677. |
This comment has been minimized.
This comment has been minimized.
comment:6
It would be nice if this could be reviewed and merged rather quickly, as it's hard for me to work on other branches right now because of the large number of untracked files (>5k) coming from the editable install. |
Author: Tobias Diez |
comment:8
I'll merge in #30730 (which is on its way into the next rc) to resolve a merge conflict |
Dependencies: #30730 |
Reviewer: Matthias Koeppe |
comment:11
Unlikely that it will make it into 9.2 though. |
comment:12
Thanks nonetheless! |
Changed branch from public/build/enhancegitignore to |
As preparation for #30371, the gitignore file is extended to ignore compiled cython files (e.g. *.so) as well as the virtual environments (e.g. src/.venv). These changes are more or less copied from https://www.toptal.com/developers/gitignore/api/python,visualstudiocode.
Finally, I've also taken the opportunity to change to comments to a consistent format (simple single line comments).
Depends on #30730
CC: @mkoeppe
Component: build
Author: Tobias Diez
Branch/Commit:
d35c945
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/30673
The text was updated successfully, but these errors were encountered: