Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/pynac/dependencies: Remove giac #30718

Closed
mkoeppe opened this issue Oct 4, 2020 · 14 comments
Closed

build/pkgs/pynac/dependencies: Remove giac #30718

mkoeppe opened this issue Oct 4, 2020 · 14 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Oct 4, 2020

As noted in #21700, our pynac spkg-install script explicitly disables use of giac. So that should not be a dependency.

Removing the dependency allows for greater parallelization of the build.

This is also a step toward allowing to build Sage with ./configure --without-giac (see #30383 - configure --disable-SPKG for standard packages).

See also:

CC: @dimpase @jhpalmieri @thierry-FreeBSD @orlitzky @tobiasdiez

Component: packages: standard

Keywords: dependencies, giac, pynac

Author: Matthias Koeppe

Branch/Commit: 9c5f559

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30718

@mkoeppe mkoeppe added this to the sage-9.2 milestone Oct 4, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2020

New commits:

9c5f559build/pkgs/pynac/dependencies: Remove giac

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2020

Commit: 9c5f559

@jhpalmieri
Copy link
Member

comment:3

This looks okay, but something is wrong with other dependencies. With this branch, make pynac works. With the current develop branch, make pynac fails (on OS X + homebrew) because giac fails to build:

checking for lapack... no
configure: error: Package requirements (lapack) were not met:

No package 'lapack' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables LAPACK_CFLAGS
and LAPACK_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

Running plain "make" works, I guess because something gets built before giac which provides whatever it needs.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2020

comment:5

The giac dependencies look fine - it depends on gsl, which depends on BLAS

@jhpalmieri
Copy link
Member

comment:6

I have homebrew packages for openblas and gsl, so Sage doesn't build those. I see this error on two different machines running OS X 10.15.7, Xcode 12, and a pretty complete homebrew installation (the only thing that Sage's configure complains about is cmake). If you have access to such a machine, try make distclean; ./configure; make giac. I'm curious about how it goes.

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2020

comment:7

Yes, confirmed on my system (still with Xcode 11)

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2020

comment:8

Doing make toolchain first fixes this problem.

@jhpalmieri
Copy link
Member

comment:9

Replying to @mkoeppe:

Doing make toolchain first fixes this problem.

Followup at #30721.

@slel
Copy link
Member

slel commented Oct 5, 2020

Changed keywords from none to dependencies, giac, pynac

@slel

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@vbraun
Copy link
Member

vbraun commented Nov 1, 2020

Changed branch from u/mkoeppe/build_pkgs_pynac_dependencies__remove_giac to 9c5f559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants