Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symplectic derivation Lie algebra #30744

Closed
tscrim opened this issue Oct 8, 2020 · 16 comments
Closed

Symplectic derivation Lie algebra #30744

tscrim opened this issue Oct 8, 2020 · 16 comments
Labels
c: algebra p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@tscrim
Copy link
Collaborator

tscrim commented Oct 8, 2020

We implement it following https://arxiv.org/abs/2006.06064

Component: algebra

Keywords: lie algebras

Author: Travis Scrimshaw

Branch/Commit: 485bcca

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/30744
@tscrim tscrim added this to the sage-9.2 milestone Oct 8, 2020
@tscrim
Copy link
Collaborator Author

tscrim commented Oct 8, 2020

Commit: c86436a

@tscrim
Copy link
Collaborator Author

tscrim commented Oct 8, 2020

Branch: public/lie_algebras/symplectic_derivation-30744

@tscrim
Copy link
Collaborator Author

tscrim commented Oct 8, 2020

Changed keywords from none to lie algebras

@tscrim
Copy link
Collaborator Author

tscrim commented Oct 8, 2020

New commits:

c86436aAdding implementation of symplectic derivation Lie algebras.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

2cac9e7Adding file to references.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2020

Changed commit from c86436a to 2cac9e7

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@fchapoton
Copy link
Contributor

comment:4

some unused imports needs to be removed

header should use https://www.gnu.org/licenses/ (with https)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2020

Changed commit from 2cac9e7 to 5c24392

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

5c24392Using imports and fixing https.

@tscrim
Copy link
Collaborator Author

tscrim commented Oct 28, 2020

comment:6

Fixed.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 1, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

485bccaFixing last pyflakes warning.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 1, 2020

Changed commit from 5c24392 to 485bcca

@fchapoton
Copy link
Contributor

comment:8

ok, looks good. Although I can see some flake8 details that could be fixed.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@tscrim
Copy link
Collaborator Author

tscrim commented Nov 4, 2020

comment:9

Thank you.

@vbraun
Copy link
Member

vbraun commented Nov 15, 2020

Changed branch from public/lie_algebras/symplectic_derivation-30744 to 485bcca

@vbraun vbraun closed this as completed in 54e53cd Nov 15, 2020
@tscrim tscrim mentioned this issue Jun 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
4 participants
@vbraun @tscrim @fchapoton @mkoeppe