Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for python 3.6, universal_newlines=, not text=, must be used in run() #30758

Closed
dimpase opened this issue Oct 13, 2020 · 8 comments
Closed

for python 3.6, universal_newlines=, not text=, must be used in run() #30758

dimpase opened this issue Oct 13, 2020 · 8 comments

Comments

@dimpase
Copy link
Member

dimpase commented Oct 13, 2020

after #30740, text=True is still there, in the call to run(), and also not supported by Python 3.6.
Cf.
https://docs.python.org/3/library/subprocess.html

Changed in version 3.7: Added the text parameter, 
as a more understandable alias of universal_newlines. 
Added the capture_output parameter.

as reported on sage-release

CC: @mkoeppe @vbraun

Component: python3

Author: Dima Pasechnik

Branch/Commit: 9307ef2

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/30758

@dimpase dimpase added this to the sage-9.2 milestone Oct 13, 2020
@dimpase
Copy link
Member Author

dimpase commented Oct 13, 2020

@dimpase
Copy link
Member Author

dimpase commented Oct 13, 2020

Commit: 9307ef2

@dimpase
Copy link
Member Author

dimpase commented Oct 13, 2020

New commits:

9307ef2do not use the python3.7+ text= in run()

@dimpase
Copy link
Member Author

dimpase commented Oct 13, 2020

Author: Dima Pasechnik

@cheuberg
Copy link
Contributor

Reviewer: Clemens Heuberger

@cheuberg
Copy link
Contributor

comment:2

This solves the problem on my machine, make ptestlong passes without errors.

The python3 documentation states that "The universal_newlines argument is equivalent to text and is provided for backwards compatibility." so I do not think we can introduce any new problems here. I therefore set the ticket to postive.

@mkoeppe
Copy link
Member

mkoeppe commented Oct 13, 2020

comment:3

Thanks for fixing and testing this!

@vbraun
Copy link
Member

vbraun commented Oct 18, 2020

Changed branch from u/dimpase/python3/no_text_in_run_for_py36 to 9307ef2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants