Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage's spkg-install doesn't return failure if build failed #3078

Closed
wjp mannequin opened this issue May 2, 2008 · 2 comments
Closed

sage's spkg-install doesn't return failure if build failed #3078

wjp mannequin opened this issue May 2, 2008 · 2 comments
Assignees
@sagetrac-mabshoff
Labels
c: build p: minor / 4 t: bug
Milestone
sage-3.0.1

Comments

@wjp
Copy link
Mannequin

wjp mannequin commented May 2, 2008

If sage -ba-force failed, spkg-install accidentally returns the return value of an echo command.

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/3078
@wjp wjp mannequin added this to the sage-3.0.1 milestone May 2, 2008
@wjp wjp mannequin added c: build labels May 2, 2008
@wjp wjp mannequin assigned sagetrac-mabshoff May 2, 2008
@wjp wjp mannequin added the s: needs review label May 2, 2008
@garyfurnish
Copy link
Mannequin

garyfurnish mannequin commented May 2, 2008

comment:1

Attachment: 3078_sage_spkg-install.patch.gz

@garyfurnish garyfurnish mannequin added the s: positive review label May 2, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 2, 2008

comment:2

Merged in Sage 3.0.1.rc0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 2, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-mabshoff sagetrac-mabshoff

Labels
c: build p: minor / 4 t: bug
Projects
None yet
Milestone
sage-3.0.1
Development

No branches or pull requests
0 participants