Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check system pari for qfisom bug #30800

Closed
dimpase opened this issue Oct 20, 2020 · 12 comments
Closed

check system pari for qfisom bug #30800

dimpase opened this issue Oct 20, 2020 · 12 comments

Comments

@dimpase
Copy link
Member

dimpase commented Oct 20, 2020

#27749 did not take care about testing system Pari for this bug. This ticket doess this.

CC: @mkoeppe @orlitzky @vbraun @isuruf

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: f916905

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30800

@dimpase dimpase added this to the sage-9.2 milestone Oct 20, 2020
@dimpase

This comment has been minimized.

@orlitzky
Copy link
Contributor

comment:2

The test never should have been added in #27749 in the first place. It's an upstream bug. Now this test is copy/pasted in THREE places:

  • The upstream test suite
  • The sage test suite
  • spkg-configure.m4 for the affected package

Are we going to do this three times for every bug in every math library?

@dimpase
Copy link
Member Author

dimpase commented Oct 20, 2020

comment:3

#27749 is done and dusted. The current ticket makes sure the system pari/gp is not buggy.
We probably could have just as well checked the version of pari...

@dimpase
Copy link
Member Author

dimpase commented Oct 20, 2020

comment:4

Isuru, by the way, this bug is present in the current Conda's pari 2.11.2.

@slel
Copy link
Member

slel commented Oct 20, 2020

comment:5

Note that PARI 2.13.0 is out; upgrading
to that new version is tracked at #30801.

@mkoeppe
Copy link
Member

mkoeppe commented Oct 20, 2020

@mkoeppe
Copy link
Member

mkoeppe commented Oct 20, 2020

Changed commit from 8f10460 to f916905

@mkoeppe
Copy link
Member

mkoeppe commented Oct 20, 2020

comment:8

rebased


New commits:

f916905check system pari/gp for qfisom bug #2140

@mkoeppe
Copy link
Member

mkoeppe commented Oct 20, 2020

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Member

mkoeppe commented Oct 20, 2020

comment:9

Looking good and seems to work (tested on ubuntu-bionic-standard and ubuntu-groovy-standard)

@isuruf
Copy link
Member

isuruf commented Oct 20, 2020

comment:10

Thanks for the heads up. I update the pari package in conda to 2.11.4

@vbraun
Copy link
Member

vbraun commented Oct 24, 2020

Changed branch from u/mkoeppe/packages/pari_check_qfisom to f916905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants