Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add giac to build/pkgs/sagelib/dependencies #30858

Closed
dcoudert opened this issue Nov 3, 2020 · 7 comments
Closed

add giac to build/pkgs/sagelib/dependencies #30858

dcoudert opened this issue Nov 3, 2020 · 7 comments
Labels
c: build p: major / 3 t: bug
Milestone
sage-9.3

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Nov 3, 2020

giac is not in the dependencies for building sagelib in 9.3.beta0. Without it I cannot compile on macOS 10.15.7.

CC: @mkoeppe @dimpase

Component: build

Author: David Coudert

Branch/Commit: 6ad8dec

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30858
@dcoudert dcoudert added this to the sage-9.3 milestone Nov 3, 2020
@dcoudert
Copy link
Contributor Author

dcoudert commented Nov 3, 2020

Branch: public/build/30858_giac

@dcoudert
Copy link
Contributor Author

dcoudert commented Nov 3, 2020

Commit: 6ad8dec

@dcoudert
Copy link
Contributor Author

dcoudert commented Nov 3, 2020

comment:1

not sure it's the right way to do it. At least, with this ticket I can compile.

New commits:

6ad8dectrac #30858: add giac to build/pkgs/sagelib/dependencies

@dimpase
Copy link
Member

dimpase commented Nov 3, 2020

comment:2

lgtm, thanks

@dimpase
Copy link
Member

dimpase commented Nov 3, 2020

Reviewer: Dima Pasechnik

@dimpase

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member

vbraun commented Nov 22, 2020

Changed branch from public/build/30858_giac to 6ad8dec

@vbraun vbraun closed this as completed in 457a593 Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @dimpase @dcoudert