Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mac app #30867

Closed
mkoeppe opened this issue Nov 6, 2020 · 11 comments
Closed

Remove mac app #30867

mkoeppe opened this issue Nov 6, 2020 · 11 comments
Labels
c: build p: blocker / 1 t: bug
Milestone
sage-9.3

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Nov 6, 2020

As previously discussed in #29710.

It's unmaintained and untested. For each release, we receive reports that it is broken, most recently:
https://groups.google.com/d/msg/sage-devel/kQb2jETT34A/VI6KL4H2BgAJ

It is an obstacle to adoption of Sage by new users.
Let's remove it.

CC: @dimpase @kcrisman @jhpalmieri @vbraun

Component: build

Author: Matthias Koeppe

Branch/Commit: 1cb79bc

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30867
@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 6, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 6, 2020

Branch: u/mkoeppe/remove_mac_app

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 6, 2020

Commit: 85f4ecd

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 6, 2020

New commits:

85f4ecdsrc/mac-app: Remove

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 6, 2020

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented Nov 6, 2020

comment:3

there is also a bit to remove in docs:

$ grep -R mac-app  src/doc
src/doc/en/developer/coding_basics.rst:            mac-app/         # would no longer have to awkwardly be in extcode

and possibly elsewhere.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 6, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

1cb79bcsrc/doc/en/developer: Remove mention of mac-app

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 6, 2020

Changed commit from 85f4ecd to 1cb79bc

@dimpase
Copy link
Member

dimpase commented Nov 6, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Nov 6, 2020

comment:5

ok

@vbraun
Copy link
Member

vbraun commented Nov 15, 2020

Changed branch from u/mkoeppe/remove_mac_app to 1cb79bc

@vbraun vbraun closed this as completed in 532e475 Nov 15, 2020
@mkoeppe mkoeppe mentioned this issue Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe