Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8 for multi_polynomial_ideal.py #30880

Closed
fchapoton opened this issue Nov 9, 2020 · 13 comments
Closed

flake8 for multi_polynomial_ideal.py #30880

fchapoton opened this issue Nov 9, 2020 · 13 comments
Labels
c: commutative algebra p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@fchapoton
Copy link
Contributor

so this changes a lot of little details

CC: @tscrim @videlec

Component: commutative algebra

Author: Frédéric Chapoton

Branch/Commit: 1b04b76

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30880
@fchapoton fchapoton added this to the sage-9.3 milestone Nov 9, 2020
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30880

@fchapoton
Copy link
Contributor Author

Commit: 68f30a1

@fchapoton
Copy link
Contributor Author

New commits:

68f30a1flake8 refresh for multi_polynomial_ideal.py

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2020

Changed commit from 68f30a1 to 32f7473

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

32f7473some lgtm fixes in multi_polynomial_ideal.py

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

6617948one more detail

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2020

Changed commit from 32f7473 to 6617948

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

1b04b76fix some E701 warnings

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2020

Changed commit from 6617948 to 1b04b76

@fchapoton
Copy link
Contributor Author

comment:5

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Nov 10, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 10, 2020

comment:6

LGTM.

@vbraun
Copy link
Member

vbraun commented Nov 22, 2020

Changed branch from u/chapoton/30880 to 1b04b76

@vbraun vbraun closed this as completed in e70b894 Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: commutative algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton