New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class Function Partitions #30897
Comments
Changed keywords from partition, symmetric group, charachter to partition, symmetric group, character |
Changed branch from u/gh-tekaysquared/partn-class-fn-libgap to u/tkarn/partn-class-fn-libgap |
Changed branch from u/tkarn/partn-class-fn-libgap to none |
Branch: u/tkarn/class_funcion_partitions |
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:8
Thanks for the patch. Hopefully someone with the necessary subject-matter background will be along to review it soon. |
comment:9
Please fix the spacing in the doctest:
It looks like a space/tab mismatch that might be invisible in your editor. |
comment:10
Also, please check the empty partition [] and [3] too, just in case (ducktyping can often be fickle around such cases). If this works: LGTM! |
comment:11
Oh, and one more thing: I'm not sure any more, but there might be different implementations of symmetric groups in Sage. Does your code work with all of them? I think EDIT: Not saying that it should work with all of them; probably best to document rather than fix. |
comment:13
It turns out that the |
comment:14
Welcome to Sage development. So I have a few other additional comments for you to address:
|
Author: Trevor K. Karn |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:18
Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date. |
comment:20
Setting a new milestone for this ticket based on a cursory review. |
The current output of
SymmetricGroup(n).irreducible_characters()
is a list ofClassFunction_libgap
objects. It would be nice to take one of those class functions and instead of passing in aSymmetricGroup
element, pass in aPartition
ofn
since those represent the conjugacy classes.This could be done by checking if the input to
ClassFunction_libgap
objects arePartitions
, and if so using thedefault_representative
of the partition.CC: @slel
Component: group theory
Keywords: partition, symmetric group, character
Author: Trevor K. Karn
Branch/Commit: u/tkarn/class_funcion_partitions @
0493345
Issue created by migration from https://trac.sagemath.org/ticket/30897
The text was updated successfully, but these errors were encountered: