Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes in shuffle_product #30904

Closed
fchapoton opened this issue Nov 12, 2020 · 9 comments
Closed

changes in shuffle_product #30904

fchapoton opened this issue Nov 12, 2020 · 9 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@fchapoton
Copy link
Contributor

mainly replacing CombinatorialClass with Parent+EnumeratedSet

another step towards #12913

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 760ca5d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30904
@fchapoton fchapoton added this to the sage-9.3 milestone Nov 12, 2020
@fchapoton
Copy link
Contributor Author

Commit: bd8ac8e

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30904

@fchapoton
Copy link
Contributor Author

New commits:

bd8ac8eget rid of CombinatorialClass in shuffle_product

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

760ca5dunexpected change of behaviour in MZV

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2020

Changed commit from bd8ac8e to 760ca5d

@fchapoton
Copy link
Contributor Author

comment:3

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Nov 14, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 14, 2020

comment:4

LGTM.

@vbraun
Copy link
Member

vbraun commented Nov 22, 2020

Changed branch from u/chapoton/30904 to 760ca5d

@vbraun vbraun closed this as completed in ccccdd5 Nov 22, 2020
This was referenced Nov 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton