partial flake8 cleanup for repl/

[fchapoton]

as a general cleaning procedure.

CC: @tscrim @slel

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: da3885d

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/30964

[fchapoton]

New commits:

64efc98

some flake8 for repl

[fchapoton]

Commit: 64efc98

[fchapoton]

Branch: u/chapoton/30964

[fchapoton]

comment:2

ok, bot is morally green, please review

[slel]

comment:3

Below some "since-we-are-editing-these-lines" optional changes.

Clearly out of scope for this reformatting ticket,
so feel free to make them or not.

With all or some or none of these in,
you can set to positive_review on my behalf.

Optionally fix these comments:

-# TODO: This global variable do_preparse should be associated with an
+# TODO: This global variable _do_preparse should be associated with an
 # IPython InteractiveShell as opposed to a global variable in this
 # module.
 _do_preparse = True

-    If the file is not a Cython, Python, or a Sage file, a ``ValueError``
+    If the file is not a Cython, Python, or Sage file, a ``ValueError``

-    # Note: On Python 3 b64encode only accepts bytes, and returns bytes (yet
-    # b64decode does accept str, but always returns bytes)
+    # Note: In Python 3, b64encode only accepts bytes, and returns bytes.
     b64 = base64.b64encode(str_to_bytes(filename, FS_ENCODING,
                                         "surrogateescape"))
     return 'sage.repl.load.load(sage.repl.load.base64.b64decode("{}"),globals(),{})'.format(bytes_to_str(b64, 'ascii'), attach)

Optionally split a long line and pep8 its output:

-    return 'sage.repl.load.load(sage.repl.load.base64.b64decode("{}"),globals(),{})'.format(bytes_to_str(b64, 'ascii'), attach)
+    return ('sage.repl.load.load(sage.repl.load.base64.b64decode'
+            '("{}"), globals(), {})'.format(bytes_to_str(b64, 'ascii'), attach))

Optionally shrink two lines into one
(unless it decreases readability):

-        i = s.find('\n')
-        s = s[i + 1:]
+        s = s[s.find('\n') + 1:]

[sagetrac-git]

Changed commit from 64efc98 to e17445f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e17445f

minor details

[slel]

Reviewer: Samuel Lelièvre

[slel]

comment:6

Regarding the two flake8 complaints of patchbots.

One says

src/sage/repl/interface_magic.py:127:21 undefined name 'get_ipython'

but that seems unrelated to the changes here.

One says

src/sage/repl/interpreter.py:788:13 'line_profiler' imported but unused

but that is as intended: it is imported
in a try-except-else, only to ascertain
and record whether it is available:

        # Load the %lprun extension if available
        try:
            import line_profiler
        except ImportError:
            pass
        else:
            self.extensions.append('line_profiler')

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

fe0908e

Merge branch 'u/chapoton/30964' in 9.3.b3

[sagetrac-git]

Changed commit from e17445f to fe0908e

[fchapoton]

comment:8

after trivial rebase, setting back to positive

[kiwifb]

comment:9

Ouch that hurts

 * python3_8: running distutils-r1_run_phase python_compile_all
Traceback (most recent call last):
  File "sage_setup/docbuild/__main__.py", line 1, in <module>
    from sage_setup.docbuild import main
  File "/dev/shm/portage/sci-mathematics/sage-9999/work/sage-9999/src-python3_8/sage_setup/docbuild/__init__.py", line 57, in <module>
    import sage.all
  File "/dev/shm/portage/sci-mathematics/sage-9999/work/sage-9999/src-python3_8/build/lib/sage/all.py", line 131, in <module>
    from sage.misc.all       import *         # takes a while
  File "/dev/shm/portage/sci-mathematics/sage-9999/work/sage-9999/src-python3_8/build/lib/sage/misc/all.py", line 30, in <module>
    from .html import html
  File "/dev/shm/portage/sci-mathematics/sage-9999/work/sage-9999/src-python3_8/build/lib/sage/misc/html.py", line 19, in <module>
    from sage.misc.latex import latex
  File "/dev/shm/portage/sci-mathematics/sage-9999/work/sage-9999/src-python3_8/build/lib/sage/misc/latex.py", line 28, in <module>
    from sage.misc import sage_eval
  File "/dev/shm/portage/sci-mathematics/sage-9999/work/sage-9999/src-python3_8/build/lib/sage/misc/sage_eval.py", line 14, in <module>
    import sage.repl.preparse as preparser
  File "/dev/shm/portage/sci-mathematics/sage-9999/work/sage-9999/src-python3_8/build/lib/sage/repl/preparse.py", line 1924
    <<<<<<< HEAD

Someone left out git stuff from a merge in sage/repl/preparse.py.

[kiwifb]

comment:10

Here
vbraun@b48b1f9#diff-cc58fbd2c68d139a07abf71362b887c37b055a649591e523ecb1bdff1b894cdeR1924
and quite possibly there too
vbraun@b48b1f9#diff-cc58fbd2c68d139a07abf71362b887c37b055a649591e523ecb1bdff1b894cdeR1924

[kiwifb]

comment:11

Didn't work like I was expecting. Ignore the last comment. So we have one thing at
https://github.com/vbraun/sage/blob/b48b1f9d61ea2c774cb11a38c53a5b707e8ec00f/src/sage/repl/preparse.py#L1924

and it looks like another at
https://github.com/vbraun/sage/blob/b48b1f9d61ea2c774cb11a38c53a5b707e8ec00f/src/sage/repl/preparse.py#L1963

[vbraun]

comment:12

There are some merge conflict markers checked in %-)

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fd7416d

some flake8 for repl

[sagetrac-git]

Changed commit from fe0908e to fd7416d

[fchapoton]

comment:14

ok, sorry. Here is a clean new branch

[fchapoton]

comment:15

please review

[kiwifb]

comment:16

Looks clean. Back to positive.

[vbraun]

comment:17

merge conflict

[sagetrac-git]

Changed commit from fd7416d to da3885d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

da3885d

Merge branch 'u/chapoton/30964' in 9.3.b4

[fchapoton]

comment:19

after trivial rebase, setting back to positive

[vbraun]

Changed branch from u/chapoton/30964 to da3885d