Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbuild: make sure the files from setup.py's scripts section are copied #3097

Closed
sagetrac-mabshoff mannequin opened this issue May 3, 2008 · 10 comments
Closed

pbuild: make sure the files from setup.py's scripts section are copied #3097

sagetrac-mabshoff mannequin opened this issue May 3, 2008 · 10 comments

Comments

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 3, 2008

If one uses pbuild to build the Sage library the files from the scripts section are not copied into $SAGE_ROOT/local/bin:

      scripts = ['sage/dsage/scripts/dsage_worker.py',
                 'sage/dsage/scripts/dsage_setup.py',
                 'spkg-debian-maybe',
                ],

Ergo DSage's doctest just hang at 0% CPU use.

Cheers,

Michael

Component: pbuild

Issue created by migration from https://trac.sagemath.org/ticket/3097

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-3.0.3 milestone May 3, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin self-assigned this May 3, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin assigned garyfurnish and unassigned sagetrac-mabshoff May 4, 2008
@garyfurnish
Copy link
Mannequin

garyfurnish mannequin commented May 4, 2008

Attachment: trac_3097.patch.gz

@garyfurnish
Copy link
Mannequin

garyfurnish mannequin commented May 4, 2008

comment:3

Attachment: trac_3097_scripts.patch.gz

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 4, 2008

comment:4

The patches will not work as is:

  • this patchset, especially the bit to setup.py will break slowbuild
  • the scripts repo will be broken once you -sdist
  • what happens on clone

This is as-is not going into 3.0.1 :(.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title pbuild: make sure the files from setup.py's scripts section are copied [negative review] pbuild: make sure the files from setup.py's scripts section are copied May 4, 2008
@garyfurnish
Copy link
Mannequin

garyfurnish mannequin commented May 4, 2008

comment:5
  1. The patchset should not break slowbuild (infact the change to slowbuild should fix it for the scripts repo).
  2. I don't understand why -sdist is going to break the scripts repo. I added the files to the hg scripts repo, why will sdist break this?
  3. the dsage/web directory is a link to devel/sage/...... so it will keep pointing at the right target on clone.

@yqiang
Copy link
Mannequin

yqiang mannequin commented May 7, 2008

comment:6

I haven't been able to test this set of patches yet but from speaking with gfurnish on IRC it seems to be the right way to go to resolve the pbuild issue. I'll try these patches out and provide feedback then.

@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.0.3, sage-3.0.2 May 21, 2008
@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 23, 2008

Attachment: trac_3097-hgignore.patch.gz

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 23, 2008

Attachment: trac_3097-sdist-fix.patch.gz

Attachment: trac_3097_extcode.patch.gz

this is a slightly updated version of the original patch by Gary

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 23, 2008

Attachment: trac_3097-sdist-fix-part2.patch.gz

oops - this ought to fix the issue

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 23, 2008

comment:8

Ok, now the -sdist issue is resolved. I did an sdist followed by a full rebuild and a testall. Positive review.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title [negative review] pbuild: make sure the files from setup.py's scripts section are copied pbuild: make sure the files from setup.py's scripts section are copied May 23, 2008
@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 23, 2008

comment:9

Merged all six patches in Sage 3.0.2.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants