Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh the Knutson-Tao puzzles file #31039

Closed
fchapoton opened this issue Dec 11, 2020 · 8 comments
Closed

refresh the Knutson-Tao puzzles file #31039

fchapoton opened this issue Dec 11, 2020 · 8 comments
Labels
c: combinatorics p: minor / 4 t: enhancement
Milestone
sage-9.3

Comments

@fchapoton
Copy link
Contributor

flake8 cleanup, fix some lgtm warnings about __eq__

plus some minimal typing information

CC: @tscrim @slel

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: fd40612

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31039
@fchapoton fchapoton added this to the sage-9.3 milestone Dec 11, 2020
@fchapoton
Copy link
Contributor Author

New commits:

fd40612refresh the Knutson-Tao puzzles file

@fchapoton
Copy link
Contributor Author

Commit: fd40612

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/31039

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

comment:3

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Dec 12, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 12, 2020

comment:4

LGTM.

@vbraun
Copy link
Member

vbraun commented Dec 21, 2020

Changed branch from u/chapoton/31039 to fd40612

@vbraun vbraun closed this as completed in 3460a4a Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton