Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh Symmetric Group representations #31079

Closed
fchapoton opened this issue Dec 18, 2020 · 14 comments
Closed

refresh Symmetric Group representations #31079

fchapoton opened this issue Dec 18, 2020 · 14 comments

Comments

@fchapoton
Copy link
Contributor

as part of #12913

to get rid of CombinatorialClass

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton, Travis Scrimshaw

Branch/Commit: e6bfc93

Reviewer: Travis Scrimshaw, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/31079

@fchapoton fchapoton added this to the sage-9.3 milestone Dec 18, 2020
@fchapoton
Copy link
Contributor Author

Commit: 856fa06

@fchapoton
Copy link
Contributor Author

comment:1

Here is a first tentative, still failing. Needs help for investigating.


New commits:

856fa06first work on symmetric group representations

@fchapoton
Copy link
Contributor Author

Branch: public/ticket/31079

@tscrim
Copy link
Collaborator

tscrim commented Dec 19, 2020

comment:2

You need to pass the parent to construct the representation/element. The generic parent SymmetricGroupRepresentations_class does not know about what the default ring should be. This is something set by the subclasses. I see two options:

1 - Implement a proper parent/element system with rewriting the (internal) construction paths to use P.element_class for the appropriate parent P.
2 - Just pass the correct object during the call of SymmetricGroupRepresentation.

1 takes more work, but it is the proper way to do it. 2 is quick and will work for now. I don't think 1 is too much more work, and I can do it if you want.

@fchapoton
Copy link
Contributor Author

comment:3

Hello,
I am not sure that I am able to do either of what you propose. If you can, please do. Otherwise, I will try later.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

6f5da42Putting symmetric group reprs fully into the category framework.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2020

Changed commit from 856fa06 to 6f5da42

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e6bfc93Putting symmetric group reprs fully into the category framework.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2020

Changed commit from 6f5da42 to e6bfc93

@tscrim
Copy link
Collaborator

tscrim commented Dec 21, 2020

Author: Frédéric Chapoton, Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 21, 2020

comment:6

Okay, here is a working branch.

@tscrim
Copy link
Collaborator

tscrim commented Dec 21, 2020

Reviewer: Travis Scrimshaw, Frédéric Chapoton

@fchapoton
Copy link
Contributor Author

comment:7

good, morally green bot and the changes looks good. I am setting to positive.

@vbraun
Copy link
Member

vbraun commented Dec 27, 2020

Changed branch from public/ticket/31079 to e6bfc93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants