Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect_poles puts a gap in function plots (even if there are no poles) #31089

Closed
DaveWitteMorris opened this issue Dec 20, 2020 · 10 comments
Closed

detect_poles puts a gap in function plots (even if there are no poles) #31089

DaveWitteMorris opened this issue Dec 20, 2020 · 10 comments
Labels
c: graphics p: minor / 4 t: bug
Milestone
sage-9.3

Comments

@DaveWitteMorris
Copy link
Member

The following plot has a (big) gap around x = 0.

sage: plot(x, -1, 1, detect_poles=True, plot_points=30)
Launched png viewer for Graphics object consisting of 2 graphics primitives

The problem is that detect_poles uses 0 for the default value of exclusion_point. To fix this, we need a default value that is not in the plotting interval. (For example, we can add 1 to the right endpoint of the interval.)

Component: graphics

Keywords: detect_poles, excluded point

Author: Dave Morris

Branch/Commit: 3966dc7

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/31089
@DaveWitteMorris DaveWitteMorris added this to the sage-9.3 milestone Dec 20, 2020
@DaveWitteMorris
Copy link
Member Author

Branch: public/31089

@DaveWitteMorris
Copy link
Member Author

New commits:

1984109add trac number

@DaveWitteMorris
Copy link
Member Author

Commit: 1984109

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2020

Changed commit from 1984109 to 3966dc7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

3966dc7trac 31089 fix doctests

@DaveWitteMorris
Copy link
Member Author

comment:4

Fixed 2 doctests. (These two graphs also demonstrated the bug, but it was necessary to look closely to see the gap.)

@fchapoton
Copy link
Contributor

comment:5

ok, thanks

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@DaveWitteMorris
Copy link
Member Author

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 27, 2020

Changed branch from public/31089 to 3966dc7

@vbraun vbraun closed this as completed in 76840e0 Dec 27, 2020
@DaveWitteMorris DaveWitteMorris mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graphics p: minor / 4 t: bug
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @DaveWitteMorris