build/pkgs/gcc/spkg-configure.m4: Fix SAGE_BROKEN_GCC test

[mkoeppe]

Code in build/pkgs/gcc/spkg-configure.m4, last modified in #30128, tries to use the configure-generated file src/bin/sage-env-config as part of the SAGE_BROKEN_GCC test.

As observed in #30845, this fails on builds from a distclean source tree into a SAGE_LOCAL that has an installed g++.

CC: @dimpase @orlitzky @tobiasdiez @kliem

Component: build

Author: Matthias Koeppe

Branch/Commit: 1cf3de4

Reviewer: Tobias Diez, Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/31097

[mkoeppe]

comment:1

I think the fix could be to just take out the source sage-env-config. In this particular case (gcc, g++ installed in $SAGE_LOCAL), the variables CONFIGURED_CC etc. are not actually used; and other recent changes to sage-env should make it run OK without the sage-env-config.

[mkoeppe]

Branch: u/mkoeppe/build_pkgs_gcc_spkg_configure_m4__fix_sage_broken_gcc_test

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: 1cf3de4

[mkoeppe]

comment:3

... please test ...

---

New commits:

1cf3de4

build/pkgs/gcc/spkg-configure.m4: Fix SAGE_BROKEN_GCC test

[kliem]

Reviewer: https://github.com/kliem/sage/pull/32/checks

[tobiasdiez]

comment:5

Strange. Even with this ticket included I get

Checking whether SageMath should install SPKG gcc...
bash: /home/runner/work/sage/sage/src/bin/sage-env-config: No such file or directory
configure: Installing GCC because installed g++ is broken

https://github.com/tobiasdiez/sage/runs/1595724994?check_suite_focus=true

[mkoeppe]

comment:6

You forgot to run bootstrap.

[tobiasdiez]

comment:7

I don't think so, it's under "Install dependencies".

[mkoeppe]

comment:8

You need to change bootstrap -D to bootstrap

[mkoeppe]

comment:9

Or better, go through tox instead of doing things from scratch again

[tobiasdiez]

comment:10

Thanks! That worked. However, now I get:

-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG gcc...
checking for C compiler vendor... gnu
checking whether /usr/share/miniconda/envs/sage-build/bin/x86_64-conda-linux-gnu-c++ supports C++11 features with -std=gnu++11... yes
checking for /usr/share/miniconda/envs/sage-build/bin/x86_64-conda-linux-gnu-cc option to accept ISO C99... none needed
configure: no suitable system package found for SPKG gcc
checking for the location of crti.o... /usr/share/miniconda/envs/sage-build/bin/../x86_64-conda-linux-gnu/sysroot/usr/lib/../lib
-----------------------------------------------------------------------------

so detection is not yet working.

[tobiasdiez]

comment:11

False alarm. It is working for me now! The changes look good to me as well, but I would prefer if somebody else also has a look.

[tobiasdiez]

Changed reviewer from https://github.com/kliem/sage/pull/32/checks to Tobias Diez, ... https://github.com/kliem/sage/pull/32/checks

[kliem]

Changed reviewer from Tobias Diez, ... https://github.com/kliem/sage/pull/32/checks to Tobias Diez, Jonathan Kliem

[kliem]

comment:12

I agree, that this locks good.

[mkoeppe]

comment:13

Thanks!

[vbraun]

Changed branch from u/mkoeppe/build_pkgs_gcc_spkg_configure_m4__fix_sage_broken_gcc_test to 1cf3de4