Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rare pbuild dependency bug #3110

Closed
garyfurnish mannequin opened this issue May 6, 2008 · 4 comments
Closed

rare pbuild dependency bug #3110

garyfurnish mannequin opened this issue May 6, 2008 · 4 comments
Assignees
@garyfurnish
Labels
c: build p: blocker / 1 t: bug
Milestone
sage-3.0.2

Comments

@garyfurnish
Copy link
Mannequin

garyfurnish mannequin commented May 6, 2008

This patch corrects a bug in pbuild dependency checking that does not correctly register the pxd file dependency for a pyx file if no other files cimport the file (rare).

Component: pbuild

Keywords: pbuild

Issue created by migration from https://trac.sagemath.org/ticket/3110
@garyfurnish garyfurnish mannequin added this to the sage-3.0.2 milestone May 6, 2008
@garyfurnish garyfurnish mannequin added c: build labels May 6, 2008
@garyfurnish garyfurnish mannequin self-assigned this May 6, 2008
@garyfurnish garyfurnish mannequin added the s: needs review label May 6, 2008
@garyfurnish
Copy link
Mannequin Author

garyfurnish mannequin commented May 6, 2008

Attachment: trac_extcode_3110.patch.gz

@garyfurnish
Copy link
Mannequin Author

garyfurnish mannequin commented May 6, 2008

comment:1

This patch also modifies -ba to clean the build directory.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 6, 2008

comment:2

Path looks good to me. One thing: This patch also contains unrelated changes [besides the clean option] which are uncontroversial. I would suggest that you also add some release number that you increment on changes so we do not end up having to poke around for the exact version of pbuild when we need to debug some problem remotely.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 6, 2008

comment:3

Merged in Sage 3.0.2.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 6, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyfurnish garyfurnish

Labels
c: build p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-3.0.2
Development

No branches or pull requests
0 participants