New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refresh combinat.py #31106
Comments
Commit: |
Branch: u/chapoton/31106 |
New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
green bot, please review |
comment:4
a small possible correction - if (self.first != self.__first_from_iterator and
- self.next != self.__next_from_iterator):
+ if (self.first != self.__first_from_iterator and
+ self.next != self.__next_from_iterator): otherwise, LGTM. |
comment:5
ben, je crois que flake8 n'aime pas trop les trucs alignes avec la ligne d'apres.. |
comment:6
Ca explique pourquoi emacs aligne par défaut comme tu l'as fait. LGTM. |
Reviewer: David Coudert |
comment:7
En option, même si ce n'est pas le propos principal du ticket, |
comment:8
Et dans - sage: 2/(exp(x)+exp(-x))
+ sage: x.cosh().inverse()
1 - 1/2*x^2 + 5/24*x^4 - 61/720*x^6 + 277/8064*x^8 + O(x^10) pour gagner quelques microsecondes à chaque doctest
mais je n'insiste bien sûr pas. |
comment:9
Dans - coeffs = [0] * k + sum(([n.binomial(i) * bernoulli(n - i), 0]
- for i in range(k, n + 1, 2)), [])
- coeffs[-3] = -n / 2
+ coeffs = [0] * (n + 1)
+ coeffs[k::2] = (n.binomial(i) * bernoulli(n - i)
+ for i in range(k, n + 1, 2))
+ coeffs[-2] = -n / 2 |
comment:10
Merci pour les suggestions. |
Changed branch from u/chapoton/31106 to |
CC: @tscrim @slel
Component: combinatorics
Author: Frédéric Chapoton
Branch/Commit:
d02b275
Reviewer: David Coudert
Issue created by migration from https://trac.sagemath.org/ticket/31106
The text was updated successfully, but these errors were encountered: