New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snappy as a pip package #31180
Comments
Commit: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Author: Matthias Koeppe |
New commits:
|
comment:4
Unfortunately |
comment:5
The full list of outside dependencies for
so just using |
This comment has been minimized.
This comment has been minimized.
comment:7
Hmm, I see what you mean by |
comment:8
Looking at snappy's
Unfortunately I think the presence of wheels for |
comment:9
Would making the cypari dependency an |
comment:10
Yeah, with binary wheels the I don't think |
comment:11
It's inelegant, but I suspect that, in light of This also has the advantage it makes it less likely that this Sage pip package will need updating. This argument is especially compelling if we throw in the optional database |
comment:12
I am not sure. It does not seem like a very robust solution. Just as a data point: I seem to be having trouble installing
|
comment:13
Also
|
comment:14
Replying to @mkoeppe:
Not that it means much, but we haven't had any reports of problems with I agree it would be preferable just to pass the
Ouch, that's a bug on our part, it seems we broke the sdist tarball in 2.4.0, on all platforms, no less: we moved some files around and forgot to update |
comment:15
Replying to @mkoeppe:
Marc Culler points out the likely cause of this: there is a |
comment:16
Replying to @NathanDunfield:
I think it's actually coming from The question is where the first |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:20
Replying to @mkoeppe:
On my macOS 10.15 box, with Python in /Frameworks from Python.org, I get:
In particular, the includes start with the SnapPy specific ones and then the location of |
comment:21
Replying to @NathanDunfield:
Assuming you're using homebrew's Python, the above seems quite likely as there I get:
|
comment:22
Yes, my python3 is (Sage's venv over) homebrew python3.9 -- so this (the This is rather unfortunate and may also be the cause of the issues reported in #31132. |
comment:23
I have opened 3-manifolds/SnapPy#21 and |
Upstream: Reported upstream. No feedback yet. |
Dependencies: #31132 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:27
With the fix from #31132 (rejecting broken homebrew python3) and rejecting the broken cypari 2.4.0 via |
comment:30
Waiting for review |
comment:31
Tried it out, |
comment:32
I am very glad that we will have better support for snappy in Sage! |
Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/473272399, https://github.com/mkoeppe/sage/actions/runs/473272391, ... to Nathan Dunfield |
comment:34
This probably makes #20739 obsolete. |
Changed branch from u/mkoeppe/add_snappy_as_a_pip_package to |
Following the instructions from #31176.
(see also https://snappy.math.uic.edu/installing.html#sagemath)
Depends on #31132
Upstream: Reported upstream. No feedback yet.
CC: @NathanDunfield @culler @dimpase @videlec @slel
Component: packages: optional
Author: Matthias Koeppe
Branch/Commit:
fb5366d
Reviewer: Nathan Dunfield
Issue created by migration from https://trac.sagemath.org/ticket/31180
The text was updated successfully, but these errors were encountered: