Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admcycles as an optional package #31238

Closed
videlec opened this issue Jan 14, 2021 · 18 comments
Closed

Add admcycles as an optional package #31238

videlec opened this issue Jan 14, 2021 · 18 comments
Labels
c: packages: optional p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@videlec
Copy link
Contributor

videlec commented Jan 14, 2021

See #31164. Upstream code at https://pypi.org/project/admcycles/ and https://gitlab.com/jo314schmitt/admcycles.

CC: @mkoeppe

Component: packages: optional

Author: Vincent Delecroix

Branch/Commit: 55ae682

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31238
@videlec videlec added this to the sage-9.3 milestone Jan 14, 2021
@videlec
Copy link
Contributor Author

videlec commented Jan 14, 2021

New commits:

462fdb131236: fix hash function of permutations
82ec96431238: add admcycles as a pip package

@videlec
Copy link
Contributor Author

videlec commented Jan 14, 2021

Commit: 82ec964

@videlec
Copy link
Contributor Author

videlec commented Jan 14, 2021

Author: Vincent Delecroix

@videlec
Copy link
Contributor Author

videlec commented Jan 14, 2021

Branch: u/vdelecroix/31238

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2021

Changed commit from 82ec964 to 524362d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

524362d31238: add admcycles as a pip package

@mkoeppe
Copy link
Member

mkoeppe commented Jan 14, 2021

comment:3

The file type is missing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2021

Changed commit from 524362d to 8a63120

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8a6312031238: type file

@videlec
Copy link
Contributor Author

videlec commented Jan 14, 2021

comment:5

thanks. done.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8a92f0131238: more in SPKG.rst

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2021

Changed commit from 8a63120 to 8a92f01

@mkoeppe
Copy link
Member

mkoeppe commented Jan 15, 2021

comment:7

No space before colon in title, start with a capital letter after colon, to match format in #29655

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

55ae68231238: typographical conventions in SPKG.rst

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2021

Changed commit from 8a92f01 to 55ae682

@mkoeppe
Copy link
Member

mkoeppe commented Jan 15, 2021

Reviewer: Matthias Koeppe

@videlec
Copy link
Contributor Author

videlec commented Jan 15, 2021

comment:10

Thanks

@vbraun
Copy link
Member

vbraun commented Jan 24, 2021

Changed branch from u/vdelecroix/31238 to 55ae682

@vbraun vbraun closed this as completed in 513046f Jan 24, 2021
@mkoeppe mkoeppe mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @videlec @mkoeppe