Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes in kschur to get rid of specific product definition there #31265

Closed
fchapoton opened this issue Jan 19, 2021 · 6 comments
Closed

changes in kschur to get rid of specific product definition there #31265

fchapoton opened this issue Jan 19, 2021 · 6 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@fchapoton
Copy link
Contributor

and remove very old "temporary cruft" about this

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 5eaf228

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31265
@fchapoton fchapoton added this to the sage-9.3 milestone Jan 19, 2021
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/31265

@fchapoton
Copy link
Contributor Author

New commits:

5eaf228modernize kschur and get rid of very special product handling there

@fchapoton
Copy link
Contributor Author

Commit: 5eaf228

@tscrim
Copy link
Collaborator

tscrim commented Jan 19, 2021

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 19, 2021

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jan 31, 2021

Changed branch from u/chapoton/31265 to 5eaf228

@vbraun vbraun closed this as completed in 1d8b95d Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton