Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optional package termcap #31268

Closed
mkoeppe opened this issue Jan 20, 2021 · 10 comments
Closed

Remove optional package termcap #31268

mkoeppe opened this issue Jan 20, 2021 · 10 comments
Labels
c: packages: optional p: minor / 4 t: enhancement
Milestone
sage-9.3

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jan 20, 2021

It is not a dependency of any package and is superseded by ncurses.

The spkg appears to have been added in #12725, 8 years ago. The upstream version, 1.3.1, is from 2002.

#14405 claimed to have replaced it with ncurses.

But somehow it has survived. Let's remove it.

CC: @dimpase @jhpalmieri @vbraun @jpflori

Component: packages: optional

Author: Matthias Koeppe

Branch: 67ccca2

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/31268
@mkoeppe mkoeppe added this to the sage-9.3 milestone Jan 20, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 20, 2021

Branch: u/mkoeppe/remove_optional_package_termcap

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 20, 2021

Commit: 67ccca2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 20, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

67ccca2COPYING.txt: Remove termcap

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 20, 2021

Author: Matthias Koeppe

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:4

Good catch, I agree that we should remove it.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 20, 2021

comment:5

Thanks.

@vbraun
Copy link
Member

vbraun commented Mar 8, 2021

Changed branch from u/mkoeppe/remove_optional_package_termcap to 67ccca2

@vbraun vbraun closed this as completed in 10d3ee9 Mar 8, 2021
@slel
Copy link
Member

slel commented Jun 27, 2021

Changed commit from 67ccca2 to none

@slel
Copy link
Member

slel commented Jun 27, 2021

comment:7

Follow-up at #32068.

@slel slel mentioned this issue Jul 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
4 participants
@vbraun @jhpalmieri @slel @mkoeppe