Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR52: upgrade ubuntu system in docker image #31271

Closed
sagetrac-gitlab-bot mannequin opened this issue Jan 21, 2021 · 17 comments
Closed

MR52: upgrade ubuntu system in docker image #31271

sagetrac-gitlab-bot mannequin opened this issue Jan 21, 2021 · 17 comments

Comments

@sagetrac-gitlab-bot
Copy link
Mannequin

sagetrac-gitlab-bot mannequin commented Jan 21, 2021

Julian Rüth (@saraedum) opened a merge request at https://gitlab.com/sagemath/sage/-/merge_requests/52:


this fixes an issue with line endings in CI. The old version of
git on ubuntu xenial does not understand our .gitattributes or it does
not understand the .git directory that we copy into the docker build
context from a much newer version of git. Anyway, the broken line
endings are gone now.

Component: docker

Author: Julian Rüth

Branch/Commit: 0a96413

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/31271

@sagetrac-gitlab-bot sagetrac-gitlab-bot mannequin added this to the sage-9.3 milestone Jan 21, 2021
@fchapoton
Copy link
Contributor

comment:1

still fails on gitlab

here: https://gitlab.com/sagemath/dev/trac/-/pipelines/244687774

@fchapoton

This comment has been minimized.

@fchapoton
Copy link
Contributor

comment:2

maybe because latest is stuck at 9.0, though

@saraedum
Copy link
Member

comment:3

The CI run for this branch is here: https://gitlab.com/sagemath/dev/sage/-/jobs/976444339

It seems to work since git status --porcelain does not report any pending changes anymore.

@saraedum
Copy link
Member

comment:4

While this fixes one problem, we now have a [dochtml] Illegal instruction (core dumped) in another CI step.

@saraedum
Copy link
Member

comment:5

Probably happens because the image was built on Skylake and the tests ran on Sandy Bridge.

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Jan 21, 2021

comment:6

New commits added to merge request. I updated the commit SHA-1. New commits:

07fb9bfbuild docker image without CPU specific flags

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Jan 21, 2021

Changed commit from 2756453 to 07fb9bf

@fchapoton
Copy link
Contributor

comment:7

so needs review ?

@mkoeppe
Copy link
Member

mkoeppe commented Jan 21, 2021

comment:8

You already had ENV SAGE_FAT_BINARY yes, but you might be running into #29537 here

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Jan 21, 2021

comment:9

New commits added to merge request. I updated the commit SHA-1. New commits:

0a96413Revert "build docker image without CPU specific flags"

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Jan 21, 2021

Changed commit from 07fb9bf to 0a96413

@saraedum
Copy link
Member

comment:10

Replying to @fchapoton:

maybe because latest is stuck at 9.0, though

It fails on gitlab because the sagemath-dev:develop image is broken. (due to this very issue.)

I ran it in a separate pipeline and it seemed to work.

@saraedum
Copy link
Member

comment:11

Let's not worry about the SAGE_FAT_BINARY issue here. That's a different problem.

@fchapoton
Copy link
Contributor

comment:12

ok, let's move on

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Jan 31, 2021

Changed branch from u/galois/mrs/52/docker-attributes to 0a96413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants