Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.features: Move classes from __init__ to separate modules #31293

Closed
mkoeppe opened this issue Jan 25, 2021 · 7 comments
Closed

sage.features: Move classes from __init__ to separate modules #31293

mkoeppe opened this issue Jan 25, 2021 · 7 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jan 25, 2021

In the long term we should get rid of __init__.py so that this package can become a namespace package (see #28925)

CC: @tobiasdiez @saraedum @kiwifb @dimpase @tscrim @seblabbe

Component: refactoring

Work Issues: drop 2nd commit, rebase on #32925

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/sage_features__move_classes_from___init___to_separate_modules @ bad5d50

Issue created by migration from https://trac.sagemath.org/ticket/31293

@mkoeppe mkoeppe added this to the sage-9.3 milestone Jan 25, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 25, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 26, 2021

Commit: bad5d50

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

bad5d50sage.features: Split out module feature

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 13, 2021

comment:4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 8, 2021

Author: Matthias Koeppe

@kiwifb
Copy link
Member

kiwifb commented Jul 8, 2021

comment:6

This is just code re-org, you are just shuffling things around cut and paste style. Looks OK to me, but I'd like someone else to double check that I am not missing anything.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 24, 2021

Work Issues: drop 2nd commit, rebase on #32925

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 2, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants