Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an if statement that is never called in normal_form #31374

Closed
simonbrandhorst opened this issue Feb 10, 2021 · 10 comments
Closed

Fix an if statement that is never called in normal_form #31374

simonbrandhorst opened this issue Feb 10, 2021 · 10 comments

Comments

@simonbrandhorst
Copy link

In line 1483 in sage.quadratic_forms.genera.normal_form we have

        b = [[0,5], [2,7], [1,2], [0,3], [0,1,5], [1,2,7], [0,3,7], [0,1,3]]
        if x in b:
            w = W[-1]
            if x == [3,7]:
                w = W[0]

The second if statement is never true due to a typo.
It should be x == [0,3,7].
Actually the bug is cleaned up later so the output should be correct anyways.

Component: quadratic forms

Author: Simon Brandhorst

Branch/Commit: 7d304d6

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/31374

@simonbrandhorst
Copy link
Author

@simonbrandhorst
Copy link
Author

Commit: 89467ed

@simonbrandhorst
Copy link
Author

New commits:

89467edclean up an if statement that is never called

@fchapoton
Copy link
Contributor

comment:3

ok, let it be

@vbraun
Copy link
Member

vbraun commented Mar 9, 2021

comment:4

Reviewer name is missing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2021

Changed commit from 89467ed to 7d304d6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

7d304d6Merge branch 'develop' into t/31374/fix_an_if_statement_that_is_never_called_in_normal_form

@simonbrandhorst
Copy link
Author

comment:6

Please add your name :-)

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Mar 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants