New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an if statement that is never called in normal_form #31374
Labels
Milestone
Comments
Commit: |
New commits:
|
comment:3
ok, let it be |
comment:4
Reviewer name is missing |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
Please add your name :-) |
Reviewer: Frédéric Chapoton |
Changed branch from u/sbrandhorst/fix_an_if_statement_that_is_never_called_in_normal_form to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In line 1483 in sage.quadratic_forms.genera.normal_form we have
The second if statement is never true due to a typo.
It should be
x == [0,3,7]
.Actually the bug is cleaned up later so the output should be correct anyways.
Component: quadratic forms
Author: Simon Brandhorst
Branch/Commit:
7d304d6
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/31374
The text was updated successfully, but these errors were encountered: