New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
giac: Make cliquer a dependency, libnauty an optional dependency #31403
Comments
comment:1
Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date. |
Commit: |
Author: Matthias Koeppe |
New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:10
This is just wrong.
No
|
comment:11
But giac's configure script checks for it, as you can see in David's log file - https://06677265663247414541.googlegroups.com/attach/90d611c87bb4/giac-1.6.0.47p3.p0.log?part=0.1&view=1&vt=ANaJVrGLaLydupV_kOaooQ8utUp20bny9N8_ERIh8lxI5JIpJksif7pfvvxlCWp667Mh0l22SddAo_Dtwb0WEJnPhTnzx-6oedhUoxLfNsIYiz-YAzemBrQ |
comment:12
I am just looking at the configure script for
It is all automagic. I am fairly sure the |
comment:13
Another point is that the |
comment:14
Our nauty package also does not declare a dependency on cliquer. The dependency has to go somewhere |
comment:15
We definitely need to add |
comment:16
Replying to @kiwifb:
This certainly makes sense, given upstream nauty's inadequate build system. |
comment:17
Replying to @kiwifb:
Actually it looks like upstream nauty (and thus our package) uses a vendored copy of cliquer. |
comment:18
So on systems with nauty linking to an unvendored cliquer (Debian?), I think it will be nondeterministic whether the GIAC build picks up our libcliquer or system libcliquer. |
comment:19
Adding the dependency will remove this nondeterminism. |
comment:20
You are posting too fast for me to make coherent answers :) I guess removing the non-deterministic behavior is the best course of action. debian, gentoo, probably fedora and arch, are unvendoring. I don't know about others or anaconda and brew. |
comment:21
Sorry - I should take a break |
comment:22
It doesn't help that it is 9:50am here and I am in the middle of meetings and trying to help people with my "day job" at the same time. |
comment:24
This misses the issue of system-wide nauty, which should only be used if it's linked to libcliquer, no?
but apparently this is not the case on Ubuntu 21. |
comment:25
If ubuntu 21 uses a vendored version of cliquer, it doesn't have to be linked to an external library. That's one of the issue we have here. Some distribution will use external cliquer while some other will not. That's why the branch is just going with "let's just make sure it is always present". |
comment:26
Replying to @kiwifb:
Huh? The problem is that nauty must be linked to libcliquer (vendored or nor), not the other way around. |
comment:27
OK my phrasing may not have been the best. If ubuntu 21's nauty uses a vendored libcliquer - like the sage optional package does - it may not need libcliquer. If ubuntu 21's nauty does use an external libcliquer and it isn't installed along nauty then it is a bug in that version of ubuntu. |
comment:28
Replying to @kiwifb:
If it used a vendored libcliquer we won't be seeing this bug reported.
cc-ing Fedora's people. |
comment:31
lgtm |
Reviewer: Dima Pasechnik |
comment:32
Thanks! |
Changed branch from u/mkoeppe/giac__make_cliquer_a_dependency__libnauty_an_optional_dependency to |
giac uses
libnauty
if it finds it, so it should be an optional dependency.Also, giac uses
cliquer
if it finds it, see https://groups.google.com/g/sage-release/c/R-8gvElDIUo/m/tHvIEdaQAAAJWe add these missing dependencies.
Follow up: if
libnauty
is not configured to be installed (nor present as a system package), then we should disable its use bygiac
. The corresponding test ingiac
's configure script is not robust - it explicitly checks in/usr/local
; which may be disabled on macOS using-isysroot
.CC: @kiwifb @dimpase @wdjoyner @sagetrac-parisse @jamesjer
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
06c4df1
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/31403
The text was updated successfully, but these errors were encountered: