Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cysignals to 1.10.3 #31474

Closed
embray opened this issue Mar 9, 2021 · 24 comments
Closed

Upgrade cysignals to 1.10.3 #31474

embray opened this issue Mar 9, 2021 · 24 comments

Comments

@embray
Copy link
Contributor

embray commented Mar 9, 2021

Cysignals 1.10.3 includes a fix for #30945 and other minor bug fixes.

Before setting this ticket to positive review we need to make a final release of 1.10.3, but here is a ticket adding a beta release for testing.

CC: @fchapoton @kiwifb @dimpase @mkoeppe @kliem @collares

Component: packages: standard

Keywords: cysignals

Author: Erik Bray

Branch/Commit: 81cab2b

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/31474

@embray embray added this to the sage-9.3 milestone Mar 9, 2021
@embray
Copy link
Contributor Author

embray commented Mar 9, 2021

Commit: 79b0cfb

@embray
Copy link
Contributor Author

embray commented Mar 9, 2021

Branch: u/embray/ticket-31474

@embray
Copy link
Contributor Author

embray commented Mar 9, 2021

Work Issues: release cysignals 1.10.3 final and update spkg version, checksums

@embray
Copy link
Contributor Author

embray commented Mar 9, 2021

New commits:

79b0cfbTicket #31474: Upgrade Cysignals provisionally to 1.10.3b0 for testing.

@embray
Copy link
Contributor Author

embray commented Mar 9, 2021

Author: Erik Bray

@embray
Copy link
Contributor Author

embray commented Mar 9, 2021

comment:2

Building Sage against this is currently failing, likely due to sagemath/cysignals#134

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

comment:3

Replying to @embray:

Building Sage against this is currently failing, likely due to sagemath/cysignals#134

Yes, this is how I found out about it in the first place.

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

comment:4

After patching with ​sagemath/cysignals#134 all tests pass on my side.

@embray
Copy link
Contributor Author

embray commented Mar 10, 2021

comment:5

Replying to @kliem:

After patching with ​sagemath/cysignals#134 all tests pass on my side.

I'm testing it now too, but thanks for confirming! I'll make a release candidate after.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 10, 2021

Changed commit from 79b0cfb to 8a80376

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 10, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8a80376Update cysignals to 1.10.3rc0

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

Reviewer: https://github.com/kliem/sage/pull/40

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

comment:9

Testing this on top of #31245.

@embray
Copy link
Contributor Author

embray commented Mar 12, 2021

comment:10

Sage builds for me with this and all the tests pass except for the orthogonal one fixed at #26912.

@kliem
Copy link
Contributor

kliem commented Mar 15, 2021

comment:12

This looks good to me modulo the actual release.

@kliem
Copy link
Contributor

kliem commented Mar 15, 2021

Changed reviewer from https://github.com/kliem/sage/pull/40/checks to Jonathan Kliem

@embray
Copy link
Contributor Author

embray commented Mar 16, 2021

comment:13

Ok, I'll make the final release then. It will be unchanged from the release candidate other than some CI fixes I made (which don't change the code).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2021

Changed commit from 8a80376 to 81cab2b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

81cab2bUpdate cysignals to 1.10.3.

@embray
Copy link
Contributor Author

embray commented Mar 16, 2021

comment:15

Ok then, this should be good to go.

@embray
Copy link
Contributor Author

embray commented Mar 16, 2021

Changed work issues from release cysignals 1.10.3 final and update spkg version, checksums to none

@kliem
Copy link
Contributor

kliem commented Mar 16, 2021

comment:17

Thank you for this release.

@vbraun
Copy link
Member

vbraun commented Mar 18, 2021

Changed branch from u/embray/ticket-31474 to 81cab2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants