New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in pynac's numeric::gcd method #31477
Comments
Branch: public/31477 |
Commit: |
comment:3
Wouldn't it make sense to check that if |
comment:4
Moving to 9.4, as 9.3 has been released. |
comment:5
Replying to @tscrim:
That seems reasonable, but needs some thought, because it will change the value of the function in some cases. Without the change you suggest, I think I think your change is probably correct (so the rest of the Related ticket: #31884. PS. Once the correct behaviour has been implemented, the description of the |
comment:6
With #32386, the new patch can just be applied to the merged-in sources |
comment:8
... by doing |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Functions in pynac expect the
gcd
of two rational numbersp
andq
to be the largest numberd
, such thatp/d
andq/d
are integers (except thatgcd(0,0) = 0
). But pynac'snumeric::gcd
method says thatgcd(p,1) = 1
for allp
, which does not have to be true whenp
is not an integer.Related ticket: #24880
Component: symbolics
Keywords: gcd, pynac
Author: Dave Morris
Branch/Commit: public/31477 @
77bf8ce
Issue created by migration from https://trac.sagemath.org/ticket/31477
The text was updated successfully, but these errors were encountered: