Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: latte_int 1.7.6 #31482

Closed
mkoeppe opened this issue Mar 10, 2021 · 16 comments
Closed

Upgrade: latte_int 1.7.6 #31482

mkoeppe opened this issue Mar 10, 2021 · 16 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 10, 2021

https://github.com/latte-int/latte/releases/tag/version_1_7_6

This version finds the moved cddlib headers (as well as headers in the old location).

We also make lrslib an optional dependency only. In contrast to the dependencies 4ti2 and lidia, at runtime LattE uses lrslib only when requested explicitly by a command-line option; and Sage does not pass this command-line option.

Critical because the critical cddlib upgrade (#30319) depends on it.

CC: @kliem @kiwifb @dimpase

Component: packages: optional

Keywords: upgrade, latte_int

Author: Matthias Koeppe

Branch: 78daa99

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/31482

@mkoeppe mkoeppe added this to the sage-9.3 milestone Mar 10, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 18, 2021

Branch: u/mkoeppe/update_latte_int

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 18, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 18, 2021

Commit: 55211fa

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 18, 2021

New commits:

55211fabuild/pkgs/latte_int: Upgrade to 1.7.6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 18, 2021

Changed commit from 55211fa to 78daa99

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

78daa99build/pkgs/latte_int/dependencies: Make lrslib only an optional dependency

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented Mar 18, 2021

comment:6

Just waiting on all tests to pass locally.

@kliem
Copy link
Contributor

kliem commented Mar 18, 2021

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Mar 18, 2021

comment:7

LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 18, 2021

comment:8

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 20, 2021

Changed branch from u/mkoeppe/update_latte_int to 78daa99

@slel
Copy link
Member

slel commented Mar 20, 2021

Changed keywords from none to upgrade, latte_int

@slel
Copy link
Member

slel commented Mar 20, 2021

Changed commit from 78daa99 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants