Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configure message "SAGE_SPKG_CONFIGURE_SAGELIB: command not found" #31496

Closed
mkoeppe opened this issue Mar 15, 2021 · 12 comments
Closed

Remove configure message "SAGE_SPKG_CONFIGURE_SAGELIB: command not found" #31496

mkoeppe opened this issue Mar 15, 2021 · 12 comments
Labels
c: build: configure p: blocker / 1 t: bug
Milestone
sage-9.3

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 15, 2021

Solved by moving the configure check from
build/pkgs/sagelib/spkg-configure.m4 to configure.ac.

Critical for 9.3 as it will prevent 1000s of bug reports by concerned users

CC: @vbraun @slel @dimpase

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 9aca813

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31496
@mkoeppe mkoeppe added this to the sage-9.3 milestone Mar 15, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2021

Branch: u/mkoeppe/remove_configure_message__sage_spkg_configure_sagelib__command_not_found_

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2021

New commits:

9aca813Move AC_ARG_ENABLE for --enable-editable to configure.ac, remove build/pkgs/sagelib/spkg-configure.m4

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2021

Commit: 9aca813

@dimpase
Copy link
Member

dimpase commented Mar 21, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Mar 21, 2021

comment:3

lgtm

@slel

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 21, 2021

comment:5

Thanks.

@slel
Copy link
Member

slel commented Mar 23, 2021

comment:6

Nice. Hope this can get in the next beta.

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 29, 2021

comment:8

Setting priority to blocker to bring this ticket to the attention of the release bot.

@vbraun
Copy link
Member

vbraun commented Apr 11, 2021

Changed branch from u/mkoeppe/remove_configure_message__sage_spkg_configure_sagelib__command_not_found_ to 9aca813

@vbraun vbraun closed this as completed in 78e8276 Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
4 participants
@vbraun @dimpase @slel @mkoeppe