Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini, build/bin/write-dockerfile.sh: Do not use "make -k" by default #31574

Open
mkoeppe opened this issue Mar 28, 2021 · 7 comments
Open

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 28, 2021

... only set it in the GH Actions workflows by setting MAKE or USE_MAKEFLAGS.

This will make it less surprising for manual use.

Before merging this, we need to remember to update ci-sage.yml of upstream packages!

CC: @jhpalmieri

Component: porting

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/tox_ini__build_bin_write_dockerfile_sh__do_not_use__make__k__by_default @ 4aede69

Issue created by migration from https://trac.sagemath.org/ticket/31574

@mkoeppe mkoeppe added this to the sage-9.3 milestone Mar 28, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 28, 2021

Dependencies: #31521

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 28, 2021

Changed dependencies from #31521 to none

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 28, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 28, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 28, 2021

comment:5

As a wishlist item (noted in #29146), for uniformity perhaps we can use environment variable MAKE for docker builds as well, instead of asking users to pass the USE_MAKEFLAGS variable.


New commits:

ba13cd0.github/workflows/ci-cygwin-*.yml: Use 'make -k' explicitly
3df8fc9.github/workflows/tox*.yml: Give the main workflow step a name so it looks nicer on GH Actions
cf41b79.github/workflows/tox-*.yml: Use 'make -k' explicitly
11fc6a1.github/workflows/ci-wsl.yml: Use 'make -k' explicitly
4aede69tox.ini, build/bin/write-dockerfile.sh: Do not use 'make -k' by default

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 28, 2021

Commit: 4aede69

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 28, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 1, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant