Update matplotlib to 3.4

[antonio-rojas]

Causes some deprecation warnings due to set_dpi_cor. According to ​matplotlib/matplotlib@1843a48 this was a no-op, so we just remove it.

CC: @mkoeppe @kiwifb @timokau

Component: packages: standard

Author: Dima Pasechnik, François Bissey, Matthias Koeppe

Branch: 475a26a

Reviewer: François Bissey, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31580

[antonio-rojas]

Branch: u/arojas/update_matplotlib_to_3_4

[antonio-rojas]

Commit: c2e282b

[antonio-rojas]

comment:2

---

New commits:

282ff30	Remove call to deprecated set_dpi_cor
c2e282b	Update matplotlib to 3.4.0

[kiwifb]

comment:3

At this stage, I don't think that will make it in 9.3 unless there was something critical about it. That being said, would matplotlib 3.3.x work just as well with that line removed?

[antonio-rojas]

comment:4

Replying to @kiwifb:

At this stage, I don't think that will make it in 9.3 unless there was something critical about it. That being said, would matplotlib 3.3.x work just as well with that line removed?

Sure, I didn't expect it to - just didn't change the default Milestone value. I haven't tested, but given that the line in question didn't have any effect (according to the upstream commit I linked) I don't expect there to be any issues with 3.3.x

[kiwifb]

comment:5

I didn't really see your link earlier. Probably a bit too early in the morning for me to process information properly. In any case I was wondering if it would be OK to just squeeze that change in since it is a no-op anyway.

[antonio-rojas]

comment:7

Replying to @kiwifb:

I didn't really see your link earlier. Probably a bit too early in the morning for me to process information properly. In any case I was wondering if it would be OK to just squeeze that change in since it is a no-op anyway.

As usual, I wrote in the comment box instead of the description. Yes, would be nice to remove that line for 9.3 - would save me some garbage output when doctesting.

[mkoeppe]

comment:8

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review.

[mkoeppe]

comment:9

3.4.2 is out

[sagetrac-git]

Changed commit from c2e282b to 426b67a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

426b67a

Update matplotlib to 3.4.2

[antonio-rojas]

Author: Antonio Rojas

[kiwifb]

comment:12

LGTM

[kiwifb]

Reviewer: François Bissey

[vbraun]

comment:13

Build tries to download additional source files:

  copying lib/matplotlib/backends/web_backend/all_figures.html -> build/lib.linux-x86_64-3.9/matplotlib/backends/web_backend
  copying lib/matplotlib/mpl-data/fonts/pdfcorefonts/ZapfDingbats.afm -> build/lib.linux-x86_64-3.9/matplotlib/mpl-data/fonts/pdfcorefonts
  copying lib/matplotlib/mpl-data/fonts/afm/pagd8a.afm -> build/lib.linux-x86_64-3.9/matplotlib/mpl-data/fonts/afm
  copying lib/matplotlib/mpl-data/images/qt4_editor_options.svg -> build/lib.linux-x86_64-3.9/matplotlib/mpl-data/images
  copying lib/matplotlib/mpl-data/images/zoom_to_rect.png -> build/lib.linux-x86_64-3.9/matplotlib/mpl-data/images
  UPDATING build/lib.linux-x86_64-3.9/matplotlib/_version.py
  set build/lib.linux-x86_64-3.9/matplotlib/_version.py to '3.4.2'
  running build_ext
  error: Failed to download any of the following: ['http://www.qhull.org/download/qhull-2020-src-8.0.2.tgz'].  Please download one of these urls and extract it into 'build/' at the top-level of the source repository.
  Building wheel for matplotlib (setup.py): finished with status 'error'
  ERROR: Failed building wheel for matplotlib

[kiwifb]

comment:75

Looks like some wrong install_name was used on that qhull install. Is qhull supposed to come from conda, brew or sage internals on OSX during those testruns?

It is a bit strange it wasn't seen before.

[kiwifb]

comment:76

OK, qhull used to be optional and has been switched to standard with this release. Unfortunately boiler plate sdh_cmake doesn't set install_name properly for qhull. I am not sure how it all install in the proper places but to get the right rpath and install_name, -DLIB_INSTALL_DIR=... has to be passed to camke when configuring.

I'll fix that ASAP. This would affect the further upgrade to 3.5.1.

[kiwifb]

Changed branch from u/dimpase/packages/matplotlib/3_4 to u/fbissey/MPL3_4

[kiwifb]

comment:77

Should work now.

---

New commits:

0018e34	Merge branch 'develop' into MPL3_4
0e5c130	Specify custom variable LIB_INSTALL_DIR for qhull, it controls rpath and install_name settings on OSX

[kiwifb]

Changed commit from 62792d4 to 0e5c130

[kiwifb]

Changed author from Dima Pasechnik to Dima Pasechnik, François Bissey

[mkoeppe]

comment:79

Also cppy is missing install-requires.txt.

[mkoeppe]

Changed branch from u/fbissey/MPL3_4 to u/mkoeppe/MPL3_4

[mkoeppe]

New commits:

475a26a

build/pkgs/cppy/install-requires.txt: New

[mkoeppe]

Changed commit from 0e5c130 to 475a26a

[mkoeppe]

Changed author from Dima Pasechnik, François Bissey to Dima Pasechnik, François Bissey, Matthias Koeppe

[vbraun]

Changed branch from u/mkoeppe/MPL3_4 to 475a26a

[fchapoton]

Changed commit from 475a26a to none