Adding convex_hull to Berkovich space

[EnderWannabe]

We add a convex_hull function to projective Berkovich space which allows the visualization of the convex hull of finite set of points. The convex hull is the smallest path-connected subspace that contains all points.

We add infinity, the Gauss point, and 0 to the convex hull as reference points and plot the resulting tree, highlighting the convex hull.

CC: @bhutz @pfili

Component: padics

Author: Alexander Galarraga

Branch/Commit: u/gh-EnderWannabe/convex_hull @ 0535e69

Issue created by migration from https://trac.sagemath.org/ticket/31635

[EnderWannabe]

Branch: u/gh-EnderWannabe/convex_hull

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e5316ac

31635: added examples and tests

[sagetrac-git]

Commit: e5316ac

[mkoeppe]

comment:4

Setting a new milestone for this ticket based on a cursory review.

[mkoeppe]

comment:5

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

[fchapoton]

comment:6

you should rather return a GraphPlot object, not show it

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

39f3f65

Merge branch 'u/gh-EnderWannabe/convex_hull' of git://trac.sagemath.org/sage into convex_hull

[sagetrac-git]

Changed commit from e5316ac to 39f3f65

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0535e69

31635: changed return type and keywords

[sagetrac-git]

Changed commit from 39f3f65 to 0535e69

[fchapoton]

comment:12

+src/sage/schemes/berkovich/berkovich_space.py:829:81: E711 comparison to None should be 'if cond is None:'
+src/sage/schemes/berkovich/berkovich_space.py:831:19: E711 comparison to None should be 'if cond is not None:'

[fchapoton]

comment:13

and doc does not build

py:docstring of sage.schemes.berkovich.berkovich_space.Berkovich_Cp_Projective.convex_hull:26: WARNING: Inline strong start-string without end-string