Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean BezierPath constructor #31646

Closed
videlec opened this issue Apr 11, 2021 · 13 comments
Closed

clean BezierPath constructor #31646

videlec opened this issue Apr 11, 2021 · 13 comments
Labels
c: graphics p: blocker / 1 t: bug
Milestone
sage-9.3

Comments

@videlec
Copy link
Contributor

videlec commented Apr 11, 2021

From http://ask.sagemath.org/question/56608/possible-problem-in-bezier_pathpy/

Component: graphics

Keywords: bug

Author: Vincent Delecroix

Branch/Commit: 33a9e9d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31646
@videlec videlec added this to the sage-9.3 milestone Apr 11, 2021
@videlec
Copy link
Contributor Author

videlec commented Apr 11, 2021

Branch: u/vdelecroix/31646

@videlec
Copy link
Contributor Author

videlec commented Apr 11, 2021

Author: Vincent Delecroix

@videlec
Copy link
Contributor Author

videlec commented Apr 11, 2021

Commit: 8d2ef75

@videlec
Copy link
Contributor Author

videlec commented Apr 11, 2021

New commits:

8d2ef7531646: clean BezierPath constructor

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2021

Changed commit from 8d2ef75 to 33a9e9d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

33a9e9d31646: remove import of unused deepcopy

@tscrim
Copy link
Collaborator

tscrim commented Apr 16, 2021

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 16, 2021

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Apr 16, 2021

comment:4

Bumping to 9.4 since we are in the 9.3.rc stage.

@tscrim tscrim modified the milestones: sage-9.3, sage-9.4 Apr 16, 2021
@videlec
Copy link
Contributor Author

videlec commented Apr 20, 2021

comment:5

Note that this is a bug fix and used to break the conversion to 3d.

@videlec
Copy link
Contributor Author

videlec commented Apr 26, 2021

comment:6

Let's try to squeeze in.

@videlec videlec modified the milestones: sage-9.4, sage-9.3 Apr 26, 2021
@videlec
Copy link
Contributor Author

videlec commented Apr 26, 2021

Changed keywords from none to bug

@vbraun
Copy link
Member

vbraun commented Apr 29, 2021

Changed branch from u/vdelecroix/31646 to 33a9e9d

@vbraun vbraun closed this as completed in bc54836 Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graphics p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @videlec